Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tributary to use create_db macro #448

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

davidjohnbell
Copy link
Contributor

Description

This is a continuation of pr #408. TributaryDb was split into several DBs, some helper methods to convert to/from the expected type were removed as they're covered by the macro.

Considerations

  • At the moment we do not have a naming and plurality convention for databases (e.g, EventDb vs Events). There are issues concerning matching existing structs and potential conflicts with other modules. I wonder if we could use the first namespace in the token to create a module and then drop the suffix. Usage or implementation would be impl substrate_db::Events { ... }? I am missing a convention in this implementation opting for what felt right and avoiding conflicts.

@davidjohnbell davidjohnbell changed the title chore: convert tributary to use create_db macro Convert tributary to use create_db macro Nov 21, 2023
@kayabaNerve kayabaNerve merged commit 9df8c94 into serai-dex:develop Nov 22, 2023
9 checks passed
@kayabaNerve
Copy link
Member

Looks good! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants