Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator/src/db.rs db macro implimentation #431

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

econsta
Copy link
Contributor

@econsta econsta commented Nov 15, 2023

No description provided.

@kayabaNerve
Copy link
Member

[2023-11-15T15:33:25Z DEBUG serai_coordinator] publishing transaction dedb43c6f999939a9db20274f1b653d528e44b04b3552a06fb82fa4551238a5c
thread 'tokio-runtime-worker' panicked at coordinator/src/db.rs:89:82:
called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "invalid transaction type" }

CI failures seem to be due to the PR.

Let me know if you want help finding where the discrepancy is :) Thanks for moving this over :D

@econsta
Copy link
Contributor Author

econsta commented Nov 16, 2023

I might need some help figuring out what is going wrong

@kayabaNerve
Copy link
Member

Happy to help take a look. The two tests failings may be the ones I just borked if you're off the most recent develop (absolutely my bad. PR runs worked but the code isn't overall stable enough. I'm debating reverting it...).

@kayabaNerve
Copy link
Member

Hm. coordinator key_gen failed which should execute regardless of my most recent changes. There may be some message prior stored in the DB which is no longer getting communicated... Will investigate deeper when I have a moment.

@kayabaNerve
Copy link
Member

Rebased, with no effort to fix any bugs prior present. I just need the rebase to understand what changes are up here and start correcting any errors.

@kayabaNerve
Copy link
Member

CI passed for "Misc tweaks", referring to correcting the rebase, yet I had a local test failure for "Minor tweaks", referring to nits I wanted to do before merging the PR.

I had the Batch test fail, so I'd assume it to fail for the CI too... I either broke something in my most recent commit or something's unstable.

@kayabaNerve
Copy link
Member

kayabaNerve commented Dec 7, 2023

I'm guessing some unstability. That commit is quite minor...

EDIT: #475

@kayabaNerve kayabaNerve merged commit 91a024e into serai-dex:develop Dec 7, 2023
9 checks passed
@kayabaNerve
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants