-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coordinator/src/db.rs db macro implimentation #431
Conversation
CI failures seem to be due to the PR. Let me know if you want help finding where the discrepancy is :) Thanks for moving this over :D |
I might need some help figuring out what is going wrong |
Happy to help take a look. The two tests failings may be the ones I just borked if you're off the most recent develop (absolutely my bad. PR runs worked but the code isn't overall stable enough. I'm debating reverting it...). |
Hm. coordinator key_gen failed which should execute regardless of my most recent changes. There may be some message prior stored in the DB which is no longer getting communicated... Will investigate deeper when I have a moment. |
ec5687e
to
f62dedd
Compare
Rebased, with no effort to fix any bugs prior present. I just need the rebase to understand what changes are up here and start correcting any errors. |
CI passed for "Misc tweaks", referring to correcting the rebase, yet I had a local test failure for "Minor tweaks", referring to nits I wanted to do before merging the PR. I had the Batch test fail, so I'd assume it to fail for the CI too... I either broke something in my most recent commit or something's unstable. |
I'm guessing some unstability. That commit is quite minor... EDIT: #475 |
Thanks :) |
No description provided.