Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile Parts #428

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Dockerfile Parts #428

merged 5 commits into from
Nov 13, 2023

Conversation

kayabaNerve
Copy link
Member

Breaks Dockerfiles into several commonly shared parts and uses a bash script to create the actual Dockerfiles.

Makes sh a dev dependency for working with the Dockerfiles.

Resolves #375.

…arts

Resolves #375.

Dockerfiles are still committed to the repo to avoid a dependency on bash.
@kayabaNerve kayabaNerve added improvement This could be better orchestration Docker, kubernetes, and build scripts labels Nov 12, 2023
@kayabaNerve
Copy link
Member Author

Will merge once/if CI passes. I'm still locally going through building all of the Docker images so this may not actually work quite yet.

Ensures the compromising of network-specific dependencies doesn't lead to a
compromise of the build process for all processors.
@kayabaNerve
Copy link
Member Author

Added fix for #358

@kayabaNerve kayabaNerve merged commit 351436a into develop Nov 13, 2023
8 checks passed
@kayabaNerve kayabaNerve deleted the dockerfile-parts branch November 13, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This could be better orchestration Docker, kubernetes, and build scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a Makefile to generate Dockerfiles
1 participant