Convert coordinator/tributary/nonce_decider to use create_db macro #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayabaNerve
force-pushed
the
create-db-nonce-decider
branch
from
e1a8828 to
e005e07
Compare
|
Rebased and restored "NonceDecider" so we don't have a "Db" (presumed internal to some area) floating around with higher-level logic (really just a stylistic preference of mine). Will merge once CI passes :) Thanks for working on this. Definitely much cleaner now :D |
I forgot to run git commit --amend on the prior commit :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of pr #408.
NonceDeciderwas split intoNextNonceDbandItemNonceDb, some helper methods to convert to/from the expected type were removed as they're covered by the macro.