Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate handover batch TOCTOU fix #397

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Alternate handover batch TOCTOU fix #397

merged 2 commits into from
Oct 13, 2023

Conversation

kayabaNerve
Copy link
Member

This may be a cleaner impl and accordingly preferable.

@kayabaNerve
Revert "Correct the prior documented TOCTOU"
10b46d1 
This reverts commit d50fe87.
@kayabaNerve
Correct the prior documented TOCTOU
8bb6c63 
d50fe87 edited the challenge for the Batch to
fix it. This won't produce Batch n+1 until Batch n is successfully published
and verified. It's an alternative strategy able to be reviewed, with a much
smaller impact to scope.
@kayabaNerve
Copy link
Member Author

This PR is ~2x as large, yet doesn't sprawl out over several locations. Instead, it's contained to the coordinator. I find it preferable accordingly.

@kayabaNerve kayabaNerve merged commit f6e8bc3 into develop Oct 13, 2023
13 checks passed
@kayabaNerve kayabaNerve deleted the alternate-handover-batch-toctou-fix branch October 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
coordinator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kayabaNerve