Lint and changes

- Renames InInstruction::AddLiquidity to InInstruction::SwapAndAddLiquidity
- Makes create_pool an internal function
- Makes dex-pallet exclusively create pools against a native coin
- Removes various fees
- Adds new crates to GH workflow

.github/workflows/tests.yml

@@ -62,6 +62,9 @@ jobs:
             -p serai-primitives \
             -p serai-coins-primitives \
             -p serai-coins-pallet \
+            -p serai-liquidity-tokens-primitives \
+            -p serai-dex-primitives \
+            -p serai-dex-pallet \
             -p serai-validator-sets-primitives \
             -p serai-validator-sets-pallet \
             -p serai-in-instructions-primitives \

deny.toml

@@ -55,10 +55,9 @@ exceptions = [
   { allow = ["AGPL-3.0"], name = "serai-coordinator" },
 
   { allow = ["AGPL-3.0"], name = "serai-coins-pallet" },
-
-  { allow = ["AGPL-3.0"], name = "serai-dex-pallet" },
-  { allow = ["AGPL-3.0"], name = "serai-dex-primitives" },
   { allow = ["AGPL-3.0"], name = "serai-liquidity-tokens-pallet" },
+  { allow = ["AGPL-3.0"], name = "serai-dex-primitives" },
+  { allow = ["AGPL-3.0"], name = "serai-dex-pallet" },
 
   { allow = ["AGPL-3.0"], name = "serai-in-instructions-pallet" },
 

substrate/client/src/serai/dex.rs

@@ -1,12 +1,12 @@
+use sp_core::bounded_vec::BoundedVec;
 use serai_runtime::{
   primitives::{SeraiAddress, Amount, Coin},
   dex, Dex, Runtime,
 };
 
 use subxt::tx::Payload;
-use sp_core::bounded_vec::BoundedVec;
 
-use crate::{TemporalSerai, SeraiError, Composite, scale_composite};
+use crate::{SeraiError, Composite, TemporalSerai, scale_composite};
 
 const PALLET: &str = "Dex";
 
@@ -16,28 +16,9 @@ pub type DexEvent = dex::Event<Runtime>;
 pub struct SeraiDex<'a>(pub(crate) TemporalSerai<'a>);
 impl<'a> SeraiDex<'a> {
   pub async fn all_events(&self) -> Result<Vec<DexEvent>, SeraiError> {
-    self
-      .0
-      .events::<Dex, _>(|event| {
-        matches!(
-          event,
-          DexEvent::PoolCreated { .. } |
-            DexEvent::LiquidityAdded { .. } |
-            DexEvent::SwapExecuted { .. } |
-            DexEvent::LiquidityRemoved { .. } |
-            DexEvent::Transfer { .. }
-        )
-      })
-      .await
+    self.0.events::<Dex, _>(|_| true).await
   }
 
-  pub fn create_pool(coin: Coin) -> Payload<Composite<()>> {
-    Payload::new(
-      PALLET,
-      "create_pool",
-      scale_composite(dex::Call::<Runtime>::create_pool { coin1: coin, coin2: Coin::Serai }),
-    )
-  }
   pub fn add_liquidity(
     coin: Coin,
     coin_amount: Amount,
@@ -69,11 +50,11 @@ impl<'a> SeraiDex<'a> {
     address: SeraiAddress,
   ) -> Payload<Composite<()>> {
     let path = if to_coin.is_native() {
-      BoundedVec::truncate_from(vec![from_coin, Coin::Serai])
+      BoundedVec::try_from(vec![from_coin, Coin::Serai]).unwrap()
     } else if from_coin.is_native() {
-      BoundedVec::truncate_from(vec![Coin::Serai, to_coin])
+      BoundedVec::try_from(vec![Coin::Serai, to_coin]).unwrap()
     } else {
-      BoundedVec::truncate_from(vec![from_coin, Coin::Serai, to_coin])
+      BoundedVec::try_from(vec![from_coin, Coin::Serai, to_coin]).unwrap()
     };
 
     Payload::new(

substrate/client/src/serai/mod.rs

@@ -35,10 +35,10 @@ use serai_runtime::{
 
 pub mod coins;
 pub use coins::SeraiCoins;
-pub mod in_instructions;
-pub use in_instructions::SeraiInInstructions;
 pub mod dex;
 pub use dex::SeraiDex;
+pub mod in_instructions;
+pub use in_instructions::SeraiInInstructions;
 pub mod validator_sets;
 pub use validator_sets::SeraiValidatorSets;
 
@@ -349,14 +349,14 @@ impl<'a> TemporalSerai<'a> {
     SeraiCoins(self)
   }
 
-  pub fn in_instructions(self) -> SeraiInInstructions<'a> {
-    SeraiInInstructions(self)
-  }
-
   pub fn dex(self) -> SeraiDex<'a> {
     SeraiDex(self)
   }
 
+  pub fn in_instructions(self) -> SeraiInInstructions<'a> {
+    SeraiInInstructions(self)
+  }
+
   pub fn validator_sets(self) -> SeraiValidatorSets<'a> {
     SeraiValidatorSets(self)
   }

substrate/client/tests/common/dex.rs

@@ -7,22 +7,6 @@ use subxt::config::extrinsic_params::BaseExtrinsicParamsBuilder;
 
 use crate::common::{serai, tx::publish_tx};
 
-#[allow(dead_code)]
-pub async fn create_pool(coin: Coin, nonce: u32, pair: Pair) -> [u8; 32] {
-  let serai = serai().await;
-
-  let tx = serai
-    .sign(
-      &PairSigner::new(pair),
-      &SeraiDex::create_pool(coin),
-      nonce,
-      BaseExtrinsicParamsBuilder::new(),
-    )
-    .unwrap();
-
-  publish_tx(&tx).await
-}
-
 #[allow(dead_code)]
 pub async fn add_liquidity(
   coin: Coin,