add missing current step checks

serai-dex · Aug 11, 2024 · 98628a7 · 98628a7
1 parent 7f2d47d
commit 98628a7
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/coordinator/tributary/tendermint/src/lib.rs b/coordinator/tributary/tendermint/src/lib.rs
@@ -709,12 +709,16 @@ impl<N: Network + 'static> TendermintMachine<N> {
       match self.network.validate(block).await {
         Ok(()) => {}
         Err(BlockError::Temporal) => {
-          self.broadcast(Data::Prevote(None));
+          if self.block.round().step == Step::Propose {
+            self.broadcast(Data::Prevote(None));
+          }
           Err(TendermintError::Temporal)?;
         }
         Err(BlockError::Fatal) => {
           log::warn!(target: "tendermint", "validator proposed a fatally invalid block");
-          self.broadcast(Data::Prevote(None));
+          if self.block.round().step == Step::Propose {
+            self.broadcast(Data::Prevote(None));
+          }
           self
             .slash(
               msg.sender,
@@ -733,7 +737,9 @@ impl<N: Network + 'static> TendermintMachine<N> {
           target: "tendermint",
           "proposed proposed with a syntactically invalid valid round",
         );
-        self.broadcast(Data::Prevote(None));
+        if self.block.round().step == Step::Propose {
+          self.broadcast(Data::Prevote(None));
+        }
         self
           .slash(msg.sender, SlashEvent::WithEvidence(Evidence::InvalidValidRound(msg.encode())))
           .await;