Skip to content

Commit

Permalink
No longer run processor tests again when testing against 0.17.3.2
Browse files Browse the repository at this point in the history
Even though the intent was to test against 0.17.3.2, and a Monero 0.17.3.2 node
was running, the processor now uses docker which will always use 0.18.
Accordingly, while the intent was valid, it was pointless.

This is unfortunate, as testing against 0.17 helped protect against edge cases.
The infra to preserve their tests isn't worth the benefit we'd gain from said
tests however.
  • Loading branch information
kayabaNerve committed Oct 26, 2023
1 parent 3069138 commit 86ff0ae
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/monero-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,4 @@ jobs:
- name: Run Integration Tests
# Don't run if the the tests workflow also will
if: ${{ matrix.version != 'v0.18.2.0' }}
run: |
GITHUB_CI=true RUST_BACKTRACE=1 cargo test --package monero-serai --all-features --test '*'
GITHUB_CI=true RUST_BACKTRACE=1 cargo test --package serai-processor --all-features monero
run: GITHUB_CI=true RUST_BACKTRACE=1 cargo test --package monero-serai --all-features --test '*'
8 changes: 6 additions & 2 deletions processor/src/tests/literal/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,13 @@ mod monero {

async fn monero(ops: &DockerOperations) -> Monero {
let handle = ops.handle("serai-dev-monero").host_port(18081).unwrap();
// TODO: Replace with a check if the node has booted
tokio::time::sleep(core::time::Duration::from_secs(20)).await;
let monero = Monero::new(format!("http://serai:seraidex@{}:{}", handle.0, handle.1));
for _ in 0 .. 60 {
if monero.get_latest_block_number().await.is_ok() {
break;
}
tokio::time::sleep(core::time::Duration::from_secs(1)).await;
}
while monero.get_latest_block_number().await.unwrap() < 150 {
monero.mine_block().await;
}
Expand Down

0 comments on commit 86ff0ae

Please sign in to comment.