Skip to content

Commit

Permalink
monero: investigated TODO and can remove it
Browse files Browse the repository at this point in the history
The behavior appears to match monero core. monero core isn't
throwing an exception in the linked code, it's returning
boost::none (and logging an error) which is the same functional
behavior as finding that the output does not belong to the user.
  • Loading branch information
j-berman committed Jan 5, 2024
1 parent 93e85c5 commit 183e35e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion coins/monero/src/wallet/scan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ impl Scanner {
// https://github.com/monero-project/monero/
// blob/04a1e2875d6e35e27bb21497988a6c822d319c28/
// src/cryptonote_basic/cryptonote_format_utils.cpp#L1062
// TODO: Should this return? Where does Monero set the trap handler for this exception?
continue;
}
None => {
Expand Down

0 comments on commit 183e35e

Please sign in to comment.