feat: raise custom timeout error

lib/factiva/authentication.rb

@@ -51,6 +51,10 @@ def make_request(params)
       end
 
       response_body
+    rescue HTTP::TimeoutError
+      # This error should be handled before HTTP::Error which is a superclass of HTTP::TimeoutError
+      # Raising Factiva::TimeoutError is required for CircuitBreaker to work properly
+      raise Factiva::TimeoutError
     end
 
     def expired?(timestamp)

lib/factiva/errors.rb

@@ -1,3 +1,5 @@
 module Factiva
-  class RequestError < StandardError; end
+  class Error < StandardError; end
+  class RequestError < Error; end
+  class TimeoutError < Error; end
 end

lib/factiva/monitoring.rb

@@ -204,8 +204,8 @@ def make_request(http_method, url, params = nil)
         end
       rescue HTTP::TimeoutError
         # This error should be handled before HTTP::Error which is a superclass of HTTP::TimeoutError
-        # Raising HTTP::TimeoutError is required for CircuitBreaker to work properly
-        raise
+        # Raising Factiva::TimeoutError is required for CircuitBreaker to work properly
+        raise Factiva::TimeoutError
       rescue SocketError, HTTP::Error => error
         Failure("Failed to connect to Factiva: #{error.message}")
       rescue JSON::ParserError => error

lib/factiva/request.rb

@@ -121,8 +121,8 @@ def make_request(method, url, params = nil)
         end
       rescue HTTP::TimeoutError
         # This error should be handled before HTTP::Error which is a superclass of HTTP::TimeoutError
-        # Raising HTTP::TimeoutError is required for CircuitBreaker to work properly
-        raise
+        # Raising Factiva::TimeoutError is required for CircuitBreaker to work properly
+        raise Factiva::TimeoutError
       rescue SocketError, HTTP::Error => error
         Failure("Failed to connect to Factiva: #{error.message}")
       rescue JSON::ParserError => error

spec/factiva/authentication_spec.rb

@@ -58,8 +58,8 @@ module Factiva
           WebMock.stub_request(:post, /oauth2\/v1\/token/).to_timeout
         end
 
-        it "raises HTTP::TimeoutError for CircuitBreaker" do
-          expect { subject.token }.to raise_error(HTTP::TimeoutError)
+        it "raises Factiva::TimeoutError for CircuitBreaker" do
+          expect { subject.token }.to raise_error(Factiva::TimeoutError)
         end
       end
     end

spec/factiva/monitoring_spec.rb

@@ -171,10 +171,10 @@ module Factiva
           WebMock.stub_request(:get, /risk-entity-screening-cases/).to_timeout
         end
 
-        it "raises HTTP::TimeoutError for CircuitBreaker" do
+        it "raises Factiva::TimeoutError for CircuitBreaker" do
           expect {
             subject.get_matches({ case_id: "id" })
-          }.to raise_error(HTTP::TimeoutError)
+          }.to raise_error(Factiva::TimeoutError)
         end
       end
     end

spec/factiva/request_spec.rb

@@ -126,10 +126,10 @@ module Factiva
           WebMock.stub_request(:post, /riskentities\/search/).to_timeout
         end
 
-        it "raises HTTP::TimeoutError for CircuitBreaker" do
+        it "raises Factiva::TimeoutError for CircuitBreaker" do
           expect {
             subject.search(**params)
-          }.to raise_error(HTTP::TimeoutError)
+          }.to raise_error(Factiva::TimeoutError)
         end
       end
     end
@@ -184,10 +184,10 @@ module Factiva
           WebMock.stub_request(:get, /riskentities\/profiles/).to_timeout
         end
 
-        it "raises HTTP::TimeoutError for CircuitBreaker" do
+        it "raises Factiva::TimeoutError for CircuitBreaker" do
           expect {
             subject.profile(profile_id)
-          }.to raise_error(HTTP::TimeoutError)
+          }.to raise_error(Factiva::TimeoutError)
         end
       end
     end