Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed spack support #79

Merged
merged 1 commit into from
Oct 6, 2024
Merged

removed spack support #79

merged 1 commit into from
Oct 6, 2024

Conversation

munishchouhan
Copy link
Member

This spark will remove spack support from wave cli

@munishchouhan
removed spack
ce3c79c 
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan munishchouhan marked this pull request as draft September 26, 2024 15:01
@munishchouhan
Copy link
Member Author

this also needs change in libseqera

 wave-cli % ./app/build/native/nativeCompile/wave --wave-endpoint http://localhost:9090 --platform linux/arm64 --conda-package salmon 
java.lang.AssertionError: Missing field in io.seqera.wave.api.PackagesSpec$Type
        at com.squareup.moshi.StandardJsonAdapters$EnumJsonAdapter.<init>(StandardJsonAdapters.java:282)
        at com.squareup.moshi.StandardJsonAdapters$1.create(StandardJsonAdapters.java:68)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:146)
        at com.squareup.moshi.ClassJsonAdapter$1.createFieldBindings(ClassJsonAdapter.java:145)
        at com.squareup.moshi.ClassJsonAdapter$1.create(ClassJsonAdapter.java:107)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:146)
        at com.squareup.moshi.ClassJsonAdapter$1.createFieldBindings(ClassJsonAdapter.java:145)
        at com.squareup.moshi.ClassJsonAdapter$1.create(ClassJsonAdapter.java:107)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:146)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:106)
        at com.squareup.moshi.Moshi.adapter(Moshi.java:80)
        at io.seqera.wave.cli.json.JsonHelper.toJson(JsonHelper.java:45)
        at io.seqera.wave.cli.Client.submit(Client.java:117)
        at io.seqera.wave.cli.App.run(App.java:405)
        at io.seqera.wave.cli.App.main(App.java:233)
        at [email protected]/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
Caused by: java.lang.NoSuchFieldException: SPACK
        at [email protected]/java.lang.Class.checkField(DynamicHub.java:1041)
        at [email protected]/java.lang.Class.getField(DynamicHub.java:1026)
        at com.squareup.moshi.StandardJsonAdapters$EnumJsonAdapter.<init>(StandardJsonAdapters.java:278)
        ... 15 more

@munishchouhan
Copy link
Member Author

PR :
seqeralabs/libseqera#22

@munishchouhan
Copy link
Member Author

tested with the new libseqera PR

wave-cli % ./app/build/native/nativeCompile/wave --wave-endpoint http://localhost:9090 --platform linux/arm64 --conda-package salmon 
wave.eu.ngrok.io/wt/5031358f057b/hrma017/dev:salmon--ab743bde24ef0467

@pditommaso pditommaso marked this pull request as ready for review October 6, 2024 10:32
@pditommaso pditommaso merged commit 72e23e1 into master Oct 6, 2024
13 checks passed
@pditommaso pditommaso deleted the remove-spack branch October 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@munishchouhan @pditommaso