Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated all spack related classes and methods #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Deprecated all spack related classes and methods #22

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7031cb
Deprecated all spack related classes and methods
munishchouhan Jul 4, 2024
6830958
removed spack
munishchouhan Sep 26, 2024
3b3ce3f
Merge branch 'master' into deprecate-spack
munishchouhan Sep 26, 2024
fa1e60b
fixed test
munishchouhan Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions wave-api/src/main/java/io/seqera/wave/api/PackagesSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ public PackagesSpec withCondaOpts(CondaOpts opts) {
return this;
}

@Deprecated
public PackagesSpec withSpackOpts(SpackOpts opts) {
this.spackOpts = opts;
return this;
Expand Down
1 change: 1 addition & 0 deletions wave-api/src/main/java/io/seqera/wave/config/SpackOpts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
*
* @author Marco De La Pierre <[email protected]>
*/
@Deprecated
public class SpackOpts {

public static final SpackOpts EMPTY = new SpackOpts();
Expand Down
3 changes: 3 additions & 0 deletions wave-utils/src/main/java/io/seqera/wave/util/DockerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ public static String condaEnvironmentToCondaYaml(String env, List<String> channe
return dumpCondaYaml(root);
}

@Deprecated
static public List<String> spackPackagesToList(String packages) {
if( packages==null || packages.isEmpty() )
return null;
Expand All @@ -220,6 +221,7 @@ static public List<String> spackPackagesToList(String packages) {
return result;
}

@Deprecated
static public String spackPackagesToSpackYaml(String packages, SpackOpts opts) {
if( opts==null )
opts = SpackOpts.EMPTY;
Expand Down Expand Up @@ -399,6 +401,7 @@ static private String joinCommands(List<String> commands) {
return result.toString();
}

@Deprecated
public static Path addPackagesToSpackFile(String spackFile, SpackOpts opts) {
// Case A - both empty, nothing to do
if( StringUtils.isEmpty(spackFile) && StringUtils.isEmpty(opts.basePackages) )
Expand Down