EDU-427: Add Data Studios events to audit log table #344
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jason-seqera
force-pushed
the
EDU-427-add-audit-log-events
branch
2 times, most recently
from
65ff29e to
31c98bb
Compare
jason-seqera
force-pushed
the
EDU-427-add-audit-log-events
branch
from
31c98bb to
0a8f48c
Compare
justinegeffen
approved these changes
Dec 12, 2024
|
This looks good to me! Preview also isn't working for me so once @robnewman approves we can merge and check in prod. |
robnewman
approved these changes
Dec 12, 2024
| @@ -15,6 +15,14 @@ | |||
| Resource: 'Data Explorer cloud buckets' | |||
| Events logged: 'Add, edit, delete, hide, show' | |||
| Note: 'Events for public and private buckets are logged.' | |||
| - | |||
| Resource: 'Data Studios sessions' | |||
| Events logged: 'Add, started, connected, disconnected, stopped, deleted' | |||
There was a problem hiding this comment.
Suggested change
| Events logged: 'Add, started, connected, disconnected, stopped, deleted' | |
| Events logged: 'Add, start, connect, disconnect, stop, delete' |
There was a problem hiding this comment.
None of the other audit log entry verbs are past tense - they are all present tense.
| Note: 'Does not include temporary states (starting, stopping, deleting)' | ||
| - | ||
| Resource: 'Data Studios custom environments' | ||
| Events logged: 'Build started, build succeeded, build failed' |
There was a problem hiding this comment.
Suggested change
| Events logged: 'Build started, build succeeded, build failed' | |
| Events logged: 'Build start, build success, build fail' |
| @@ -15,6 +15,14 @@ | |||
| Resource: 'Data Explorer cloud buckets' | |||
| Events logged: 'Add, edit, delete, hide, show' | |||
There was a problem hiding this comment.
Just noticed this - you can't delete a cloud bucket (!), but you can remove it from Data Explorer
Suggested change
| Events logged: 'Add, edit, delete, hide, show' | |
| Events logged: 'Add, edit, remove, hide, show' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview not working for this -- puzzling. But the Files changed is correct.