Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray executor can request resources for workers #766

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

zigaLuksic
Copy link
Collaborator

Kinda hard to test :/ ideas welcome

@zigaLuksic zigaLuksic requested a review from mlubej October 26, 2023 13:59
Copy link
Contributor

@mlubej mlubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically what was already discussed in the pair session

@mlubej
Copy link
Contributor

mlubej commented Oct 26, 2023

I'm also not sure about testing this without actually properly running things on the cluster.

@zigaLuksic
Copy link
Collaborator Author

I'm also not sure about testing this without actually properly running things on the cluster.

i guess we could try and request too much of a resource and then try and catch the warning?

@mlubej
Copy link
Contributor

mlubej commented Oct 26, 2023

i guess we could try and request too much of a resource and then try and catch the warning?

Seems like if you ask for a non-existing resource, or for a larger resource chunk than it exists, the process just stalls

@zigaLuksic
Copy link
Collaborator Author

i guess we could try and request too much of a resource and then try and catch the warning?

Seems like if you ask for a non-existing resource, or for a larger resource chunk than it exists, the process just stalls

yeah, but on the cluster it returns a warning. But i cant remember if it does that inside the python runtime as well, might just be a log message.

@mlubej
Copy link
Contributor

mlubej commented Oct 27, 2023

No further ideas about the tests...

@zigaLuksic zigaLuksic merged commit a0d6b28 into develop Oct 27, 2023
7 checks passed
@zigaLuksic zigaLuksic deleted the forward-ray-kwargs branch October 27, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants