-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ray executor can request resources for workers #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically what was already discussed in the pair session
I'm also not sure about testing this without actually properly running things on the cluster. |
i guess we could try and request too much of a resource and then try and catch the warning? |
Seems like if you ask for a non-existing resource, or for a larger resource chunk than it exists, the process just stalls |
yeah, but on the cluster it returns a warning. But i cant remember if it does that inside the python runtime as well, might just be a log message. |
No further ideas about the tests... |
Kinda hard to test :/ ideas welcome