Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation by pinning whois gem v4 #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoshikazusawa
Copy link

Pull Request Checklist

Is this in reference to an existing issue?

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

The recent update of the whois gem to version 6.0.0 has raised the minimum required Ruby version to 3.0.
https://rubygems.org/gems/whois/versions/6.0.0

This change has caused the sensu-install -p sensu-plugins-network-checks command to fail with the following error:

sensu-install -p sensu-plugins-network-checks
[SENSU-INSTALL] installing Sensu plugins ...
[SENSU-INSTALL] determining if Sensu gem 'sensu-plugins-network-checks' is already installed ...
false
[SENSU-INSTALL] Sensu plugin gems to be installed: ["sensu-plugins-network-checks"]
[SENSU-INSTALL] installing Sensu gem 'sensu-plugins-network-checks'
ERROR:  Error installing sensu-plugins-network-checks:
        whois requires Ruby version >= 3.0.

To address this issue, I have pinned the whois gem to the last compatible major version 4.

Known Compatibility Issues

@yoshikazusawa
Copy link
Author

Hi,

Could someone please review this pull request when you have a moment?
I'd appreciate any feedback or approval.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant