Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tests improvements #18

Merged
merged 23 commits into from
Dec 10, 2015
Merged

Various tests improvements #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c5c9097
Refactor to be order independant
paolochiodi Oct 8, 2015
aed8a12
Fix remove behaviour according to #15
paolochiodi Oct 8, 2015
c074ed3
proper merge behaviour
paolochiodi Oct 8, 2015
13397ab
tests for mandatory merge option
paolochiodi Oct 8, 2015
eb5258c
allow null or undefined for missing attributes
paolochiodi Oct 8, 2015
2ec67ae
change sql tests style
paolochiodi Oct 8, 2015
aa186e5
cleanup and uniform style
paolochiodi Oct 8, 2015
ce9bb7d
follow the standard style
paolochiodi Oct 9, 2015
72279e7
update dependencies and add proper seneca dependencies
paolochiodi Oct 9, 2015
7f48943
remove unneded test runner
paolochiodi Oct 9, 2015
3a87ff1
add tests for invalid skip and limit
paolochiodi Oct 9, 2015
c2d55fd
make updates work like upserts
paolochiodi Oct 9, 2015
acc3a65
support opaque ids on list
paolochiodi Oct 9, 2015
c416e7d
tests for common save mistakes
paolochiodi Oct 9, 2015
38ace29
test for native support
paolochiodi Oct 9, 2015
00acb82
add tests around attributes mixing between entity and query
paolochiodi Oct 14, 2015
21128d3
fix error on id
paolochiodi Oct 20, 2015
d2c106e
assert correct behaviour for load$, list$ and remove$ without query
paolochiodi Oct 22, 2015
577434d
better test for no query on load$
paolochiodi Oct 22, 2015
8e460bd
fix typo
paolochiodi Oct 22, 2015
0592375
use seneca merge instance to setup tests
paolochiodi Nov 10, 2015
d3bfcf2
Make sure merge$ command doesn't leak
paolochiodi Nov 10, 2015
bd32ad9
update seneca dependency and explicitly require mem store
paolochiodi Nov 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Standard test cases for seneca stores",
"main": "store-test.js",
"scripts": {
"test": "lab test/*.test.js -r console -v -L -m 3000 -t 80",
"test": "lab test/*.test.js -r console -v -L -t 80",
"annotate": "docco store-test.js -o doc"
},
"repository": {
Expand All @@ -23,23 +23,26 @@
"Mircea Alexandru (https://www.alexandrumircea.ro/)"
],
"license": "MIT",
"dependencies": {
"async": "^1.5.0",
"chai": "^3.4.1",
"nid": "^0.3.2",
"lodash": "^3.10.1"
},
"files": [
"README.md",
"LICENSE.txt",
"store-test.js"
],
"dependencies": {
"async": "^1.4.0",
"chai": "^3.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should move into devDependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure here. These are dependencies needed to run this package, not to test it.
That's because this package is kind of meta in that it is used to run tests. seneca-store-test will be among the devDependencies of other stores, but async and chai are required to make this work.
In fact I actually think I should move even lab here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regular dependencies is fine here. The package is a test package so these are its direct dependencies.

"lodash": "^3.10.1"
},
"peerDependencies": {
"seneca": ">=0.8.0 <0.9.0"
},
"devDependencies": {
"lab": "^7.3.0",
"docco": "0.6.3",
"eslint-config-seneca": "1.x.x",
"eslint-plugin-hapi": "2.x.x",
"eslint-plugin-standard": "1.x.x",
"docco": "0.7.0",
"seneca": "~0.7.0"
"lab": "^6.2.0",
"seneca": "plugin",
"seneca-mem-store": "~0.4.0"
}
}
Loading