[WIP] Reorganize and refactor #20
Conversation
|
After setting up MySQL I tested this with |
paolochiodi
force-pushed
the
reorganize
branch
from
e83ba6a to
d4f45df
Compare
|
@paolochiodi @colmharte Is this ok to be merged? |
|
Mostly. IIRC package.json should point to the now-released version of seneca store test, and README needs some updates |
|
Awesome, I'm going push the new doc after lunch for this so. Just wanted to make sure 💃 |
|
Readme updated as of #21 |
|
@paolochiodi Can you check the conflicts on this? |
|
@mcdonnelldean I'll give a look to this, but I'm wondering if it's worth the effort to release a version now or if it's better to wait that this senecajs/seneca-store-test#18 gets merged and the new version of seneca-store-test gets published |
This makes the store compatible with seneca 0.6 Seneca 0.6 expects the returned object to store methods to be an array, an entity or null. There's still no direction about what should be returned in the remove callback (pg store returns number of deleted rows, mongo the deleted entity). Because returning the deleted entity will require two different queries (thus double roundtrip to the db) we are switching to returning null until the proper design gets defined
Also remove duplicate tests
paolochiodi
force-pushed
the
reorganize
branch
from
6abf2c3 to
47c53ad
Compare
|
rebased to fix conflicts |
|
@paolochiodi I'll do some maintenance work on this. can you please solve the conflicts again? thanks :) |
|
@paolochiodi any news on this? can you please rebase to fix conflicts? |
|
I'm sorry, no. |
|
@paolochiodi no worries. This week is fine. thanks |
|
@paolochiodi @ckiss i started working today on the mysql plugin. I will fix also this PR |
|
thanks @mihaidma |
|
@mihaidma @paolochiodi What's the story with this PR? is it still valid? It needs resolving if so. |
|
@mcdonnelldean I am currently working on postgres but by tomorrow I will switch to mysql. Mysql will use seneca-standard-query for query generation and all this PR will be probably cancelled. I will not close it until I look over the fixes not to lose any info. |
|
@mihaidma awesome stuff 👍 |
|
the mysql was unified with the postgres one (and reusing the postgres code), this won't be merged as the code is not the same anymore |
WIP refresh of the store to adhere to new stores structure and make it work with newer versions of seneca and node (builds on top of #19)