ci: fix link checker comment on PR workflow #317
Merged
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@demoore can you take a look at this? Non members can't add assignees / reviewers |
|
oh hey, this looks like it's working great. Thanks, @zevisert ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiddling around a bit more with GHA, sorry for the noise! It's a little difficult to contribute this kind of workflow without being an owner on this repo since the tokens granted to PRs from forks don't include permissions to write comments on forks. I've now confirmed this workflow's functionality on our fork, and I think it should work fine here now too. I'm going to close #316 one more time and wait for this to land before trying once more there.
I hope this is correct now, at least I have evidence of it working on our fork: revela-systems#7 (comment)