Fix DurationValidator when field value is empty #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
changed the title
|
I've added to changes.rst ))) HAPPY NEW YEAR! |
ramonski
approved these changes
Jan 3, 2022
Lunga001
added a commit
to bikalims/senaite.core
that referenced
this pull request
Feb 12, 2022
commit 2605e4c Author: Ramon Bartl <[email protected]> Date: Thu Feb 10 09:00:57 2022 +0100 Added SENAITE maintenance scripts (senaite#1933) * Added senaite scripts runtime and first script * Added upgrade script * Added reindex script * Changelog updated * Always upgrade the latest versions * Fixed import commit 27353ad Author: Jordi Puiggené <[email protected]> Date: Wed Feb 9 20:57:58 2022 +0100 Fix cannot attach documents to individual analyses in Worksheet context (senaite#1932) * Fix cannot set attachments to specific analyses in Worksheet * Remove unnecessary code * Changelog commit 269f1b1 Author: Ramon Bartl <[email protected]> Date: Mon Feb 7 12:49:21 2022 +0100 Ensure valid timezone in DX datetime field setter (senaite#1930) * Ensure valid timezone in field setter * Changelog updated * Convert GMT timezones to Etc/GMT pytz timezones * Whitespace only * Date API takes care of DateTime conversion * Better Timezone conversion * Added a note regarding the Etc/GMT Timezone * Leverate datetime API for field conversions * Check for None type * Make Etc/GMT the default fallback commit 8092b0d Author: Jordi Puiggené <[email protected]> Date: Mon Jan 31 10:53:57 2022 +0100 Analysis attachment is copied on retest (senaite#1927) * Skip "Attachment" field on analysis' field values copy * Changelog Co-authored-by: Ramon Bartl <[email protected]> commit 01df928 Author: Ramon Bartl <[email protected]> Date: Mon Jan 31 10:44:56 2022 +0100 Added `on_change` hook for methods in analyses listings (senaite#1928) * Added on_change handler for Methods * Changelog updated * Enable _on_change_method on worksheet's results entry view Co-authored-by: Jordi Puiggené <[email protected]> commit 88d3053 Author: Ramon Bartl <[email protected]> Date: Thu Jan 27 08:38:22 2022 +0100 Updated Translations from Transifex (senaite#1926) * updated translations * fixed i18n errors commit 7200333 Author: Ramon Bartl <[email protected]> Date: Wed Jan 26 11:23:11 2022 +0100 Fix sample transition in listings (senaite#1925) * Don't set sample date if already set * Convert field getter names back to field name * Imports only * Fixed datetime conversion in sample listing when sample wf is active * Fixed workflow adapter for sample transition in listings * Changelog updated * Allow to set min/max values for datetime field commit b0506d8 Author: Ramon Bartl <[email protected]> Date: Tue Jan 25 17:08:51 2022 +0100 Fix viewlet rendering error on login screen (senaite#1924) * Hide socialtags viewlets * Update CHANGES.rst * Update CHANGES.rst Co-authored-by: Jordi Puiggené <[email protected]> commit a030d92 Author: Ramon Bartl <[email protected]> Date: Tue Jan 25 17:04:35 2022 +0100 Use native date input fields in reports (senaite#1923) * Use native date input fields in reports * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit 61fb6f3 Author: Ramon Bartl <[email protected]> Date: Mon Jan 24 12:14:58 2022 +0100 Fix indexed attributes not set when adding a new index with catalog API (senaite#1920) * Fixed catalog API indexed attributes not set when adding a new index * Changelog updated commit 0e81ba7 Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 17:14:03 2022 +0100 Always call object info adapter with a record (senaite#1919) commit 28a3169 Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 17:11:15 2022 +0100 Fix stale combobox items displayed when search query changed (senaite#1918) * Force combobox close when search query changed * Remove portal_factory check in combobox JS * Handle portal_factory urls * Generated coffee script * Changelog updated commit 314f80b Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 12:01:18 2022 +0100 Fix wrong context in reference widget lookups (senaite#1917) * Use absolute context url for reference widget lookups * Changelog updated commit 8a1f37c Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 10:32:46 2022 +0100 Provide the request record to object info adapters in the sample add form (senaite#1916) * Provide the request record to object info adapters * Changelog * Removed argument for base method commit 6cb368f Author: Ramon Bartl <[email protected]> Date: Thu Jan 20 15:17:04 2022 +0100 Ported PR senaite#1865 for dexterity contents (senaite#1913) * Ported PR senaite#1865 for dexterity contents * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit f15e188 Author: Ramon Bartl <[email protected]> Date: Thu Jan 20 15:14:13 2022 +0100 Support list queries in dx reference widget (senaite#1915) * Build production JS * Support lists for catalog queries in DX reference widget * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit cb77fc3 Author: Ramon Bartl <[email protected]> Date: Thu Jan 20 15:11:34 2022 +0100 Provide context, widget and fieldname for callable base queries in AT reference widgets (senaite#1914) * Call base query callable with context, widget and fieldname * Changelog updated * Return the dereferenced base query commit b077f7e Author: Ramon Bartl <[email protected]> Date: Wed Jan 19 13:47:46 2022 +0100 Fixed typo in sample view (senaite#1912) * Fixed typo * Changelog updated commit 6c5fa8a Author: Ramon Bartl <[email protected]> Date: Mon Jan 17 12:07:47 2022 +0100 Avoid parse errors for ZCTextIndex (senaite#1910) Traceback (innermost last): Module ZServer.ZPublisher.Publish, line 144, in publish Module ZPublisher.mapply, line 85, in mapply Module ZServer.ZPublisher.Publish, line 44, in call_object Module senaite.app.listing.view, line 216, in __call__ Module senaite.app.listing.ajax, line 109, in handle_subpath Module senaite.core.decorators, line 20, in decorator Module senaite.app.listing.decorators, line 63, in wrapper Module senaite.app.listing.decorators, line 50, in wrapper Module senaite.app.listing.decorators, line 100, in wrapper Module senaite.app.listing.ajax, line 432, in ajax_folderitems Module senaite.app.listing.decorators, line 88, in wrapper Module senaite.app.listing.ajax, line 313, in get_folderitems Module senaite.app.listing.view, line 901, in folderitems Module senaite.app.listing.view, line 715, in _fetch_brains Module senaite.app.listing.view, line 781, in search Module senaite.app.listing.view, line 708, in text_index_search Module Products.CMFPlone.CatalogTool, line 463, in searchResults Module Products.ZCatalog.ZCatalog, line 625, in searchResults Module Products.ZCatalog.Catalog, line 1091, in searchResults Module Products.ZCatalog.Catalog, line 634, in search Module Products.ZCatalog.Catalog, line 564, in _search_index Module Products.ZCTextIndex.ZCTextIndex, line 209, in query_index Module Products.ZCTextIndex.QueryParser, line 153, in parseQuery Module Products.ZCTextIndex.QueryParser, line 193, in _parseOrExpr Module Products.ZCTextIndex.QueryParser, line 211, in _parseAndExpr Module Products.ZCTextIndex.QueryParser, line 233, in _parseNotExpr Module Products.ZCTextIndex.QueryParser, line 241, in _parseTerm Module Products.ZCTextIndex.QueryParser, line 260, in _parseAtom Module Products.ZCTextIndex.QueryParser, line 188, in _get Module Products.ZCTextIndex.QueryParser, line 174, in _require ParseError: Token <Token:ATOM> required, u'OR' found commit 6173111 Author: Ramon Bartl <[email protected]> Date: Sun Jan 16 12:41:22 2022 +0100 Allow to navigate and select with arrow keys in dexterity reference widget (senaite#1909) * Fixed results highlighting * Allow to navigate and select results with arrow keys * Changelog updated * Allow to navigate pages with left/right keys * Search on keydown and clear on backspace Co-authored-by: Jordi Puiggené <[email protected]> commit 1f22fec Author: Ramon Bartl <[email protected]> Date: Sun Jan 16 12:39:28 2022 +0100 Added searchable text querystring converter to catalog API (senaite#1908) * Added searchable text querystring converter to catalog API * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit cd037c6 Author: Ramon Bartl <[email protected]> Date: Sun Jan 16 12:20:31 2022 +0100 Fix datetime field/widget shows current date and time if empty (senaite#1907) * Fix datetime widget shows current date if empty This also happened for older `datetime.date` objects in the DB * Changelog updated * Support date strings in date API * Raise API Error instead commit 14eff7b Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 20:14:12 2022 +0100 Revert "Check for a date value in widget" This reverts commit 97b18cb. commit be3d500 Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 10:07:34 2022 +0100 Revert "Support date strings in date API" This reverts commit 708a051. commit b10395b Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 10:07:11 2022 +0100 Revert "Revert "Fix empty field in sample add form when using edit accessor (senaite#1905)"" This reverts commit 9f654ad. commit 9f654ad Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 10:04:27 2022 +0100 Revert "Fix empty field in sample add form when using edit accessor (senaite#1905)" This reverts commit b1f8126. commit 97b18cb Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 09:56:55 2022 +0100 Check for a date value in widget commit 708a051 Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 09:56:13 2022 +0100 Support date strings in date API commit b1f8126 Author: Ramon Bartl <[email protected]> Date: Thu Jan 13 13:27:17 2022 +0100 Fix empty field in sample add form when using edit accessor (senaite#1905) * Fix empty field in sample add form when using edit accessor * Changelog updated * Fixed buildout version commit c96fa99 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:21:06 2022 +0100 Update release notes commit b5681b4 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:14:55 2022 +0100 Version bump v2.2.0 commit 862acfd Merge: 84f1089 80a16ab Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:04:25 2022 +0100 Release 2.1.0 (220105) commit 80a16ab Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:03:18 2022 +0100 Update translations commit c848b04 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 10:51:55 2022 +0100 Added translators commit abff9e6 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 10:17:54 2022 +0100 Fix NestingError commit 8fbea94 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 10:05:15 2022 +0100 Update contributors commit 5ddb91e Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 09:45:51 2022 +0100 Version change 2.0.1 --> 2.1.0 commit 84f1089 Author: Ramon Bartl <[email protected]> Date: Tue Jan 4 19:18:04 2022 +0100 Added date and time field/widget for Dexterity contents (senaite#1903) * Implemented datetime field * Custom setter for datetime field * Implemented datetime widget * Handle timezones * Added datetime API * Always localize the date on field level * Datetime widget refactored to use the date API * Extended API * Check if timezone is callable This can be the case when the `default_timezone` is set through a directive on the widget, e.g.: from plone.app.event.base import default_timezone * Changelog updated * Updated scrutinizer config * Added API function to generate a POSIX timestamp * Added from_timestamp API function * Added ISO format API * Handle Python date objects * Dropped get_min/get_max methods * Test fixed for TZ * Fixed datetimewidget display value * Test fixture * Fixed test commit 2d6cc35 Author: Ramon Bartl <[email protected]> Date: Mon Jan 3 16:57:19 2022 +0100 Allow date fields to be unset (senaite#1904) commit 985b8f1 Author: toropok <[email protected]> Date: Mon Jan 3 21:22:32 2022 +0700 Fix DurationValidator when field value is empty (senaite#1890) * Update DurationValidator * Update CHANGES.rst commit 8779528 Author: Jordi Puiggené <[email protected]> Date: Thu Dec 23 15:38:41 2021 +0100 Ensure `get_tool` returns a tool when a name is set as the default param (senaite#1902) * Ensure get_tool's default returns a tool * Added doctest commit 13498f3 Author: Ramon Bartl <[email protected]> Date: Mon Dec 20 15:15:30 2021 +0100 Fix snapshot listing fails on orphan catalog entries (senaite#1900) * Fix snapshot listing fails on orphan catalog entries * Changelog updated commit c219b22 Author: Ramon Bartl <[email protected]> Date: Mon Dec 20 15:14:05 2021 +0100 Improved style for datetimewidget w/o hard coded width (senaite#1901) This fixes a side effect in the results table view commit 0755ba7 Author: Ramon Bartl <[email protected]> Date: Wed Dec 15 12:09:15 2021 +0100 Fix archetype tool catalog mappings (senaite#1898) * Fix archetype tool catalog mappings * Comment added commit 4eb6c68 Author: Ramon Bartl <[email protected]> Date: Tue Dec 14 09:45:22 2021 +0100 Support date and number fields copy in sample add form (senaite#1897) * Copy date/time/hidden fields * Changelog commit 6256c38 Author: Ramon Bartl <[email protected]> Date: Mon Dec 13 10:35:15 2021 +0100 Custom date and time widget (senaite#1896) * Always show time if long_format is requested * Imports sorted * Changed datetimewidget properties in instrumentcertification * Fixed TZ offset issue in "valid to" instrument certification field * Updated datetimewidget to display date and time separate * Hide time input if show_only is false * Added JS docstrings * Changelog updated * Avoid time cropping in FireFox * Make form controls 260px wide * Conditional widths commit 15dd407 Author: Ramon Bartl <[email protected]> Date: Thu Dec 9 16:49:13 2021 +0100 Disable native form validation in header table (senaite#1895) * No native form validation in header table * Changelog updated commit 91b4bc0 Author: Ramon Bartl <[email protected]> Date: Wed Dec 8 17:40:44 2021 +0100 Removed unused field PasswordLifeTime (senaite#1893) * Removed blind field PasswordLifeTime * Changelog updated commit 6cbbfb4 Author: Ramon Bartl <[email protected]> Date: Wed Dec 8 12:21:26 2021 +0100 Drop jQuery Datepicker for HTML5 native date fields (senaite#1892) * Removed jQuery timepicker JS * removed jquery timepicker from webpack config * rebuild production js * removed datetime js from site * Use HTML date or datetime-local input field * Added copy functionality in add form for date fields * Return ISO8601 format * Changelog updated * Removed * Use manual formatted date format for min/max * datetime-local field requires local date format w/o timezone * Use correct datetime field * Removed malicious DateTime field in bika namespace * Comment only
Lunga001
added a commit
to bikalims/senaite.core
that referenced
this pull request
Feb 12, 2022
commit 2605e4c Author: Ramon Bartl <[email protected]> Date: Thu Feb 10 09:00:57 2022 +0100 Added SENAITE maintenance scripts (senaite#1933) * Added senaite scripts runtime and first script * Added upgrade script * Added reindex script * Changelog updated * Always upgrade the latest versions * Fixed import commit 27353ad Author: Jordi Puiggené <[email protected]> Date: Wed Feb 9 20:57:58 2022 +0100 Fix cannot attach documents to individual analyses in Worksheet context (senaite#1932) * Fix cannot set attachments to specific analyses in Worksheet * Remove unnecessary code * Changelog commit 269f1b1 Author: Ramon Bartl <[email protected]> Date: Mon Feb 7 12:49:21 2022 +0100 Ensure valid timezone in DX datetime field setter (senaite#1930) * Ensure valid timezone in field setter * Changelog updated * Convert GMT timezones to Etc/GMT pytz timezones * Whitespace only * Date API takes care of DateTime conversion * Better Timezone conversion * Added a note regarding the Etc/GMT Timezone * Leverate datetime API for field conversions * Check for None type * Make Etc/GMT the default fallback commit 8092b0d Author: Jordi Puiggené <[email protected]> Date: Mon Jan 31 10:53:57 2022 +0100 Analysis attachment is copied on retest (senaite#1927) * Skip "Attachment" field on analysis' field values copy * Changelog Co-authored-by: Ramon Bartl <[email protected]> commit 01df928 Author: Ramon Bartl <[email protected]> Date: Mon Jan 31 10:44:56 2022 +0100 Added `on_change` hook for methods in analyses listings (senaite#1928) * Added on_change handler for Methods * Changelog updated * Enable _on_change_method on worksheet's results entry view Co-authored-by: Jordi Puiggené <[email protected]> commit 88d3053 Author: Ramon Bartl <[email protected]> Date: Thu Jan 27 08:38:22 2022 +0100 Updated Translations from Transifex (senaite#1926) * updated translations * fixed i18n errors commit 7200333 Author: Ramon Bartl <[email protected]> Date: Wed Jan 26 11:23:11 2022 +0100 Fix sample transition in listings (senaite#1925) * Don't set sample date if already set * Convert field getter names back to field name * Imports only * Fixed datetime conversion in sample listing when sample wf is active * Fixed workflow adapter for sample transition in listings * Changelog updated * Allow to set min/max values for datetime field commit b0506d8 Author: Ramon Bartl <[email protected]> Date: Tue Jan 25 17:08:51 2022 +0100 Fix viewlet rendering error on login screen (senaite#1924) * Hide socialtags viewlets * Update CHANGES.rst * Update CHANGES.rst Co-authored-by: Jordi Puiggené <[email protected]> commit a030d92 Author: Ramon Bartl <[email protected]> Date: Tue Jan 25 17:04:35 2022 +0100 Use native date input fields in reports (senaite#1923) * Use native date input fields in reports * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit 61fb6f3 Author: Ramon Bartl <[email protected]> Date: Mon Jan 24 12:14:58 2022 +0100 Fix indexed attributes not set when adding a new index with catalog API (senaite#1920) * Fixed catalog API indexed attributes not set when adding a new index * Changelog updated commit 0e81ba7 Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 17:14:03 2022 +0100 Always call object info adapter with a record (senaite#1919) commit 28a3169 Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 17:11:15 2022 +0100 Fix stale combobox items displayed when search query changed (senaite#1918) * Force combobox close when search query changed * Remove portal_factory check in combobox JS * Handle portal_factory urls * Generated coffee script * Changelog updated commit 314f80b Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 12:01:18 2022 +0100 Fix wrong context in reference widget lookups (senaite#1917) * Use absolute context url for reference widget lookups * Changelog updated commit 8a1f37c Author: Ramon Bartl <[email protected]> Date: Fri Jan 21 10:32:46 2022 +0100 Provide the request record to object info adapters in the sample add form (senaite#1916) * Provide the request record to object info adapters * Changelog * Removed argument for base method commit 6cb368f Author: Ramon Bartl <[email protected]> Date: Thu Jan 20 15:17:04 2022 +0100 Ported PR senaite#1865 for dexterity contents (senaite#1913) * Ported PR senaite#1865 for dexterity contents * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit f15e188 Author: Ramon Bartl <[email protected]> Date: Thu Jan 20 15:14:13 2022 +0100 Support list queries in dx reference widget (senaite#1915) * Build production JS * Support lists for catalog queries in DX reference widget * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit cb77fc3 Author: Ramon Bartl <[email protected]> Date: Thu Jan 20 15:11:34 2022 +0100 Provide context, widget and fieldname for callable base queries in AT reference widgets (senaite#1914) * Call base query callable with context, widget and fieldname * Changelog updated * Return the dereferenced base query commit b077f7e Author: Ramon Bartl <[email protected]> Date: Wed Jan 19 13:47:46 2022 +0100 Fixed typo in sample view (senaite#1912) * Fixed typo * Changelog updated commit 6c5fa8a Author: Ramon Bartl <[email protected]> Date: Mon Jan 17 12:07:47 2022 +0100 Avoid parse errors for ZCTextIndex (senaite#1910) Traceback (innermost last): Module ZServer.ZPublisher.Publish, line 144, in publish Module ZPublisher.mapply, line 85, in mapply Module ZServer.ZPublisher.Publish, line 44, in call_object Module senaite.app.listing.view, line 216, in __call__ Module senaite.app.listing.ajax, line 109, in handle_subpath Module senaite.core.decorators, line 20, in decorator Module senaite.app.listing.decorators, line 63, in wrapper Module senaite.app.listing.decorators, line 50, in wrapper Module senaite.app.listing.decorators, line 100, in wrapper Module senaite.app.listing.ajax, line 432, in ajax_folderitems Module senaite.app.listing.decorators, line 88, in wrapper Module senaite.app.listing.ajax, line 313, in get_folderitems Module senaite.app.listing.view, line 901, in folderitems Module senaite.app.listing.view, line 715, in _fetch_brains Module senaite.app.listing.view, line 781, in search Module senaite.app.listing.view, line 708, in text_index_search Module Products.CMFPlone.CatalogTool, line 463, in searchResults Module Products.ZCatalog.ZCatalog, line 625, in searchResults Module Products.ZCatalog.Catalog, line 1091, in searchResults Module Products.ZCatalog.Catalog, line 634, in search Module Products.ZCatalog.Catalog, line 564, in _search_index Module Products.ZCTextIndex.ZCTextIndex, line 209, in query_index Module Products.ZCTextIndex.QueryParser, line 153, in parseQuery Module Products.ZCTextIndex.QueryParser, line 193, in _parseOrExpr Module Products.ZCTextIndex.QueryParser, line 211, in _parseAndExpr Module Products.ZCTextIndex.QueryParser, line 233, in _parseNotExpr Module Products.ZCTextIndex.QueryParser, line 241, in _parseTerm Module Products.ZCTextIndex.QueryParser, line 260, in _parseAtom Module Products.ZCTextIndex.QueryParser, line 188, in _get Module Products.ZCTextIndex.QueryParser, line 174, in _require ParseError: Token <Token:ATOM> required, u'OR' found commit 6173111 Author: Ramon Bartl <[email protected]> Date: Sun Jan 16 12:41:22 2022 +0100 Allow to navigate and select with arrow keys in dexterity reference widget (senaite#1909) * Fixed results highlighting * Allow to navigate and select results with arrow keys * Changelog updated * Allow to navigate pages with left/right keys * Search on keydown and clear on backspace Co-authored-by: Jordi Puiggené <[email protected]> commit 1f22fec Author: Ramon Bartl <[email protected]> Date: Sun Jan 16 12:39:28 2022 +0100 Added searchable text querystring converter to catalog API (senaite#1908) * Added searchable text querystring converter to catalog API * Changelog updated Co-authored-by: Jordi Puiggené <[email protected]> commit cd037c6 Author: Ramon Bartl <[email protected]> Date: Sun Jan 16 12:20:31 2022 +0100 Fix datetime field/widget shows current date and time if empty (senaite#1907) * Fix datetime widget shows current date if empty This also happened for older `datetime.date` objects in the DB * Changelog updated * Support date strings in date API * Raise API Error instead commit 14eff7b Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 20:14:12 2022 +0100 Revert "Check for a date value in widget" This reverts commit 97b18cb. commit be3d500 Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 10:07:34 2022 +0100 Revert "Support date strings in date API" This reverts commit 708a051. commit b10395b Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 10:07:11 2022 +0100 Revert "Revert "Fix empty field in sample add form when using edit accessor (senaite#1905)"" This reverts commit 9f654ad. commit 9f654ad Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 10:04:27 2022 +0100 Revert "Fix empty field in sample add form when using edit accessor (senaite#1905)" This reverts commit b1f8126. commit 97b18cb Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 09:56:55 2022 +0100 Check for a date value in widget commit 708a051 Author: Ramon Bartl <[email protected]> Date: Sat Jan 15 09:56:13 2022 +0100 Support date strings in date API commit b1f8126 Author: Ramon Bartl <[email protected]> Date: Thu Jan 13 13:27:17 2022 +0100 Fix empty field in sample add form when using edit accessor (senaite#1905) * Fix empty field in sample add form when using edit accessor * Changelog updated * Fixed buildout version commit c96fa99 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:21:06 2022 +0100 Update release notes commit b5681b4 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:14:55 2022 +0100 Version bump v2.2.0 commit 862acfd Merge: 84f1089 80a16ab Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:04:25 2022 +0100 Release 2.1.0 (220105) commit 80a16ab Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 11:03:18 2022 +0100 Update translations commit c848b04 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 10:51:55 2022 +0100 Added translators commit abff9e6 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 10:17:54 2022 +0100 Fix NestingError commit 8fbea94 Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 10:05:15 2022 +0100 Update contributors commit 5ddb91e Author: Jordi Puiggené <[email protected]> Date: Wed Jan 5 09:45:51 2022 +0100 Version change 2.0.1 --> 2.1.0 commit 84f1089 Author: Ramon Bartl <[email protected]> Date: Tue Jan 4 19:18:04 2022 +0100 Added date and time field/widget for Dexterity contents (senaite#1903) * Implemented datetime field * Custom setter for datetime field * Implemented datetime widget * Handle timezones * Added datetime API * Always localize the date on field level * Datetime widget refactored to use the date API * Extended API * Check if timezone is callable This can be the case when the `default_timezone` is set through a directive on the widget, e.g.: from plone.app.event.base import default_timezone * Changelog updated * Updated scrutinizer config * Added API function to generate a POSIX timestamp * Added from_timestamp API function * Added ISO format API * Handle Python date objects * Dropped get_min/get_max methods * Test fixed for TZ * Fixed datetimewidget display value * Test fixture * Fixed test commit 2d6cc35 Author: Ramon Bartl <[email protected]> Date: Mon Jan 3 16:57:19 2022 +0100 Allow date fields to be unset (senaite#1904) commit 985b8f1 Author: toropok <[email protected]> Date: Mon Jan 3 21:22:32 2022 +0700 Fix DurationValidator when field value is empty (senaite#1890) * Update DurationValidator * Update CHANGES.rst commit 8779528 Author: Jordi Puiggené <[email protected]> Date: Thu Dec 23 15:38:41 2021 +0100 Ensure `get_tool` returns a tool when a name is set as the default param (senaite#1902) * Ensure get_tool's default returns a tool * Added doctest commit 13498f3 Author: Ramon Bartl <[email protected]> Date: Mon Dec 20 15:15:30 2021 +0100 Fix snapshot listing fails on orphan catalog entries (senaite#1900) * Fix snapshot listing fails on orphan catalog entries * Changelog updated commit c219b22 Author: Ramon Bartl <[email protected]> Date: Mon Dec 20 15:14:05 2021 +0100 Improved style for datetimewidget w/o hard coded width (senaite#1901) This fixes a side effect in the results table view commit 0755ba7 Author: Ramon Bartl <[email protected]> Date: Wed Dec 15 12:09:15 2021 +0100 Fix archetype tool catalog mappings (senaite#1898) * Fix archetype tool catalog mappings * Comment added commit 4eb6c68 Author: Ramon Bartl <[email protected]> Date: Tue Dec 14 09:45:22 2021 +0100 Support date and number fields copy in sample add form (senaite#1897) * Copy date/time/hidden fields * Changelog commit 6256c38 Author: Ramon Bartl <[email protected]> Date: Mon Dec 13 10:35:15 2021 +0100 Custom date and time widget (senaite#1896) * Always show time if long_format is requested * Imports sorted * Changed datetimewidget properties in instrumentcertification * Fixed TZ offset issue in "valid to" instrument certification field * Updated datetimewidget to display date and time separate * Hide time input if show_only is false * Added JS docstrings * Changelog updated * Avoid time cropping in FireFox * Make form controls 260px wide * Conditional widths commit 15dd407 Author: Ramon Bartl <[email protected]> Date: Thu Dec 9 16:49:13 2021 +0100 Disable native form validation in header table (senaite#1895) * No native form validation in header table * Changelog updated commit 91b4bc0 Author: Ramon Bartl <[email protected]> Date: Wed Dec 8 17:40:44 2021 +0100 Removed unused field PasswordLifeTime (senaite#1893) * Removed blind field PasswordLifeTime * Changelog updated commit 6cbbfb4 Author: Ramon Bartl <[email protected]> Date: Wed Dec 8 12:21:26 2021 +0100 Drop jQuery Datepicker for HTML5 native date fields (senaite#1892) * Removed jQuery timepicker JS * removed jquery timepicker from webpack config * rebuild production js * removed datetime js from site * Use HTML date or datetime-local input field * Added copy functionality in add form for date fields * Return ISO8601 format * Changelog updated * Removed * Use manual formatted date format for min/max * datetime-local field requires local date format w/o timezone * Use correct datetime field * Removed malicious DateTime field in bika namespace * Comment only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
fix validator call from json.api.
Linked issue: senaite/senaite.jsonapi#44
Current behavior before PR
when AnalisysService resource created via json.api call it raises follow exceptions:
''NoneType' object has no attribute 'getitem'' on line 1005
Desired behavior after PR is merged
check if the field is presented in REQUEST object. If yes - validate it.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.