Skip to content

Commit

Permalink
[86bzz17jr][dropdown-menu] fixed role in menu popper (#1588)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the Title above -->

## Motivation and Context
Just fixed how to clear the role in dropdown menu popper.
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How has this been tested?
Manually
<!--- Please describe in detail how you tested your changes. -->
<!--- For example: -->
<!--- I have added unit tests -->
<!--- I have added Voice Over tests -->
<!--- Code cannot be tested automatically so I have tested it only
manually -->

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [X] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected).
- [ ] Nice improve.

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [X] My code follows the code style of this project.
- [X] I have updated the documentation accordingly or it's not required.
- [X] Unit tests are not broken.
- [X] I have added changelog note to corresponding `CHANGELOG.md` file
with planned publish date.
- [ ] I have added new unit tests on added of fixed functionality.
  • Loading branch information
ilyabrower authored Aug 13, 2024
1 parent 05b9f5d commit c11ce30
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions semcore/dropdown-menu/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

CHANGELOG.md standards are inspired by [keepachangelog.com](https://keepachangelog.com/en/1.0.0/).

## [4.35.3] - 2024-08-13

### Fixed

- Clear the role of Menu popper.

## [4.35.2] - 2024-07-31

### Changed
Expand Down
2 changes: 1 addition & 1 deletion semcore/dropdown-menu/src/DropdownMenu.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ class DropdownMenuRoot extends Component {
ignorePortalsStacking,
focusMaster: interaction === 'click',
hideFocus: highlightedIndex !== null,
'use:role': null,
};
}

Expand Down Expand Up @@ -468,7 +469,6 @@ function Menu(props) {
interaction,
autoFocus,
animationsDisabled,
role: false,
};
return (
<ListBoxContextProvider>
Expand Down

0 comments on commit c11ce30

Please sign in to comment.