Merge pull request #680 from JonasSchubert/fix/properly-parse-create-…

…fail-issue fix(fail): properly parse issue creation response to log in terminal
semantic-release · Feb 20, 2024 · 142dd15 · 142dd15
2 parents 6e0aee6 + 4014f51
commit 142dd15
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lib/fail.js b/lib/fail.js
@@ -53,10 +53,12 @@ export default async (pluginConfig, context) => {
       debug("create issue: %O", newIssue);
 
       /* eslint camelcase: off */
-      const { id, web_url } = await got.post(issuesEndpoint, {
-        ...apiOptions,
-        json: newIssue,
-      });
+      const { id, web_url } = await got
+        .post(issuesEndpoint, {
+          ...apiOptions,
+          json: newIssue,
+        })
+        .json();
       logger.log("Created issue #%d: %s.", id, web_url);
     }
   }

diff --git a/test/fail.test.js b/test/fail.test.js
@@ -72,11 +72,16 @@ Your **[semantic-release](https://github.com/semantic-release/semantic-release)*
       labels: "semantic-release",
       title: "The automated release is failing 🚨",
     })
-    .reply(200);
+    .reply(200, { id: 3, web_url: "https://gitlab.com/test_user/test_repo/-/issues/3" });
 
   await fail(pluginConfig, { env, options, branch, errors, logger: t.context.logger });
 
   t.true(gitlab.isDone());
+  t.deepEqual(t.context.log.args[0], [
+    "Created issue #%d: %s.",
+    3,
+    "https://gitlab.com/test_user/test_repo/-/issues/3",
+  ]);
 });
 
 test.serial("Post comments to existing issue", async (t) => {