chore: revert s3methods back to v2.3.3 release

[soumyaray]

Reverting breakage of S3 methods:

• rhoC_AVE_pls_model -> rhoC_AVE.pls_model
• rhoC_AVE_boot_seminr_model -> rhoC_AVE.boot_seminr_model
• rhoC_AVE_cbsem_model -> rhoC_AVE.cbsem_model
• rhoC_AVE_cfa_model -> rhoC_AVE.cfa_model
• remove \r from line ends from files
• clarify/rename as.reflective.matrix function in R/inspect_mmMatrix

[soumyaray]

New warning from rcmdcheck appearing after upgrading R to 4.4.2 and clean reinstalling all packages:

W  checking S3 generic/method consistency ...
   rhoC_AVE:
     function(x, ...)
   rhoC_AVE.pls_model:
     function(pls_model, constructs)
   See section ‘Generic functions and methods’ in the ‘Writing R
   Extensions’ manual.

From https://cran.r-project.org/doc/manuals/R-exts.html#Generic-functions-and-methods:

A method must have all the arguments of the generic, including … if the generic does.

[soumyaray]

@NicholasDanks I think I'm done with the fixes for the S3 methods, and all tests and checks are passing. I also reverted the insertion of \r (CR) to the end of lines of several files. Let's discuss how to prevent these in future.

And I also want to discuss the intent of this function:

seminr/R/inspect_mmMatrix.R

Line 158 in ae2524a

as.reflective.matrix <- function(x, ...) {

And then I think we're back on track!

[soumyaray]

@NicholasDanks I think you closed the PR without merging? Reopening it again but please let me know if you had another plan.