fix view bug #100
Merged
fix view bug #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w41ter
requested changes
Jun 3, 2024
pkg/ccr/job.go
Outdated
Comment on lines
949
to
966
| /* | ||
| Creating table will only occur when sync db. | ||
| When create view, the db name of sql is source db name, we should use dest db name to create view | ||
| */ | ||
| createSql := createTable.Sql | ||
| viewRegex := regexp.MustCompile("(?i)^CREATE(\\s+)VIEW") | ||
| isCreateView := viewRegex.MatchString(createSql) | ||
| if isCreateView { | ||
| log.Debugf("create view, use dest db name to replace source db name") | ||
|
|
||
| // replace `internal`.`source_db_name`. to `internal`.`dest_db_name`. | ||
| originalName := "`internal`.`" + strings.TrimSpace(j.Src.Database) + "`." | ||
| dbNameRegex := regexp.MustCompile(originalName) | ||
| replaceName := "`internal`.`" + strings.TrimSpace(j.Dest.Database) + "`." | ||
| createTable.Sql = dbNameRegex.ReplaceAllString(createSql, replaceName) | ||
| log.Debugf("original create view sql is %s, after repalce, now sql is %s", createSql, createTable.Sql) | ||
| } | ||
|
|
There was a problem hiding this comment.
Move SQL related operations into Spec.go:CreateTable, and add a parameter 'srcDatabase'.
createTable.Sql = dbNameRegex.ReplaceAllString(createSql, replaceName)strings.ReplaceAll is enough here.
|
|
||
| var results []string | ||
| // first, query information_schema.tables with table_schema and table_type, get all views' name | ||
| querySql := fmt.Sprintf("SELECT table_name FROM information_schema.tables WHERE table_schema = '%s' AND table_type = 'VIEW'", s.Database) |
There was a problem hiding this comment.
desc ${tableName} all might be easier and more efficient than this.
See https://doris.apache.org/docs/1.2/query-acceleration/materialized-view/#query-materialized-views.
There was a problem hiding this comment.
'desc ${tableName} all' don't support common view, materialized view is supported
pkg/ccr/job.go
Outdated
| if !allViewDeleted { | ||
| views, err := j.IDest.GetAllViewsFromTable(destTableName) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Logging errors and breaking here instead of returning, if you aim to loop?
w41ter
reviewed
Jun 3, 2024
lsy3993
added a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: walter <[email protected]>
lsy3993
added a commit
to lsy3993/ccr-syncer
that referenced
this pull request
Jun 7, 2024
Co-authored-by: walter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.