Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML bucket #13

Merged
merged 3 commits into from
Aug 13, 2024
Merged

HTML bucket #13

merged 3 commits into from
Aug 13, 2024

Conversation

chrmod
Copy link
Collaborator

@chrmod chrmod commented Aug 12, 2024

This brings all html filters into a single bucket so they don't complicate the logic in the network and cosmetic buckets.
This change accidentally optimises the unhide lookup for the cosmetic html filters as previously they were mixed with all other cosmetic unhides.
It also makes clearer how to look for the network html filters exceptions as all are in the same bucket.

The PR is still not finished (see TODO in engine.getHTMLFilters), but should be sufficient POC to review the direction.

@seia-soto seia-soto merged commit a545f4a into support-replace-mod Aug 13, 2024
3 of 4 checks passed
@seia-soto seia-soto deleted the html-bucket branch August 13, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants