Simplify html filters usage #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmod
commented
Aug 5, 2024
|
|
||
| callerContext?: any | undefined; | ||
| }): HTMLSelector[] { | ||
| public getHtmlFilters(request: Request): HTMLSelector[] { |
There was a problem hiding this comment.
wonder if this is an actually breaking change
chrmod
commented
Aug 5, 2024
Comment on lines
+13
to
+17
| export type HTMLModifier = readonly [RegExp, string]; | ||
|
|
||
| export type HTMLSelector = | ||
| | readonly ['script', readonly string[]] | ||
| | readonly ['replace', HTMLModifier]; |
There was a problem hiding this comment.
How about we rename HTMLModifier with HTMLReplacer ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to hide the complexity of different types of html filters from the users - so changes to public interfaces were removed.
Additionally support for logging and exception handling was added.