-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback should not cause missing validatorset #250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kbhat1
approved these changes
Dec 4, 2024
philipsu522
approved these changes
Dec 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 58.15% 58.17% +0.02%
==========================================
Files 249 249
Lines 34549 34555 +6
==========================================
+ Hits 20091 20102 +11
+ Misses 12860 12853 -7
- Partials 1598 1600 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem:
Currently there's a bug in rollback logic, where after rollback, the node could sometimes run into this error:
Root cause:
ValidatorSet data are not stored on every height, it was stored only when things get changed, or every interval (100k). So the root cause is that the rollback could sometimes fill LastHeightValidatorsChanged with the wrong value. The correct logic should be to use the previous block's value of LastHeightValidatorsChanged, however in some cases it will simply just set it to be rollbackHeight + 1, which could lead to not able to find the correct validator set data.
Solution:
In order to fix it, the correct way is when rollback, we need to query previous block's LastHeightValidatorsChanged and assign that as the rolled back state.
Testing performed to validate your change
Tested in archive node