Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exclude unconditional peers when connection limit checking #245

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

blindchaser
Copy link
Contributor

Describe your changes and provide context

Testing performed to validate your change

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (29b1ac3) to head (af65cbb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   58.03%   58.24%   +0.20%     
==========================================
  Files         249      249              
  Lines       34510    34510              
==========================================
+ Hits        20029    20100      +71     
+ Misses      12880    12828      -52     
+ Partials     1601     1582      -19     
Files with missing lines Coverage Δ
internal/p2p/peermanager.go 79.31% <100.00%> (ø)

... and 20 files with indirect coverage changes

@blindchaser blindchaser requested a review from yzang2019 October 17, 2024 19:20
@blindchaser blindchaser merged commit e5eddb0 into main Oct 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants