Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] check removed including wrapped tx state #235

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • if a tx has been removed from the hashedTxs, then we need to consider its state to answer is removed

Testing performed to validate your change

  • validating in atlantic-2

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.32%. Comparing base (c027db5) to head (0a6a2a2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   58.17%   58.32%   +0.15%     
==========================================
  Files         249      249              
  Lines       34441    34445       +4     
==========================================
+ Hits        20036    20091      +55     
+ Misses      12814    12765      -49     
+ Partials     1591     1589       -2     
Files Coverage Δ
internal/mempool/tx.go 83.47% <100.00%> (+0.73%) ⬆️
internal/mempool/mempool.go 72.88% <66.66%> (ø)

... and 19 files with indirect coverage changes

@stevenlanders stevenlanders merged commit 7c29db9 into main Apr 30, 2024
22 checks passed
@stevenlanders stevenlanders deleted the check-removed-including-instance-state branch April 30, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants