Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request length check to json rpcs #221

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

philipsu522
Copy link
Contributor

@philipsu522 philipsu522 commented Apr 1, 2024

Describe your changes and provide context

We should limit the request of json rpc calls

Testing performed to validate your change

  • unit tests
  • tested on remote node

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.19%. Comparing base (66ac407) to head (5d3c0e6).

❗ Current head 5d3c0e6 differs from pull request most recent head fbccf90. Consider uploading reports for the commit fbccf90 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   58.13%   58.19%   +0.05%     
==========================================
  Files         249      249              
  Lines       33935    33940       +5     
==========================================
+ Hits        19729    19752      +23     
+ Misses      12636    12626      -10     
+ Partials     1570     1562       -8     
Files Coverage Δ
rpc/jsonrpc/server/http_json_handler.go 68.31% <100.00%> (+1.65%) ⬆️

... and 17 files with indirect coverage changes

@philipsu522 philipsu522 requested a review from udpatil April 1, 2024 16:37
@philipsu522 philipsu522 enabled auto-merge (squash) April 1, 2024 16:38
@philipsu522 philipsu522 merged commit 338bb7d into main Apr 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants