Add blacklisted peers in peermanager to avoid reconnection storm #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
reviewed
Dec 21, 2023
internal/p2p/peermanager.go
Outdated
| @@ -837,6 +861,7 @@ func (m *PeerManager) Disconnected(ctx context.Context, peerID types.NodeID) { | |||
| }) | |||
| } | |||
|
|
|||
| m.blacklisted[peerID] = time.Now() | |||
There was a problem hiding this comment.
One concern of adding peer to blacklist directly is that this might just be a good peer which happen to be restarted or something. What we can do here is to keep a disconnect frequency for each peer, and only blacklist if a peer constantly disconnected in the recent time window
|
I'd also recommend switching to use https://github.com/hashicorp/golang-lru, this library makes expiration much easier to manage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We hit scenarios where disconnected peers keep getting reconnected
Testing performed to validate your change