-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sei Actions API's #194
Sei Actions API's #194
Conversation
codebycarson
commented
Aug 22, 2024
- Adds a new @sei-js/create-sei command to spin up an express API application that has an EVM and cosmos action link.
- Adds @sei-js/actions which defines the type interfaces for the action api standard on Sei
🦋 Changeset detectedLatest commit: 76b91a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 84.47% 84.47%
=======================================
Files 16 16
Lines 161 161
Branches 25 25
=======================================
Hits 136 136
Misses 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is kinda worthless, all this package does is export types, but our configuration requires at least one test to pass github actions, so I add this basic one.
packages/actions/src/types.ts
Outdated
export interface SeiActionConfig { | ||
label: string; | ||
href: string; | ||
chainType: 'EVM' | 'COSMOS'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how I plan to distinguish between the two unless we hear otherwise from OKX on how they are doing it on EVM chains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! can u also update the readme in the actions package with the new info?
@@ -0,0 +1,25 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we should include biome here, projects can add it themselves if they want it or other formatters
Add Types for actions to be used in APIs and dapps for action API's
- Added an express template to @sei-js/create-sei for an actions API using express
Fixed the linting issue by following the "exclude" naming convention
19461d6
to
3f33856
Compare