-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Metamask Snaps #103
Conversation
… with other cosmos based libraries including @sei-js - Refactored helper functions in /core
🦋 Changeset detectedLatest commit: 676fde3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
04ddfa5
to
934ae07
Compare
# Conflicts: # yarn.lock
… snap and removed helper functions from /core
910e05a
to
ef005c9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 76.56% 76.51% -0.05%
==========================================
Files 35 35
Lines 512 511 -1
Branches 122 121 -1
==========================================
- Hits 392 391 -1
Misses 120 120 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,5 @@ | |||
--- | |||
'@sei-js/core': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we also need to bump metamask-snap
version so that it has the correct core
dependency?
} | ||
} | ||
|
||
export const sendReqToSnap = async (method: string, params: any): Promise<any> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this used for anything besides metamask-snap
? if not, maybe we can just leave it in the metamask-snap
package to keep the size of core
as low as possible?
Added helper functions to /core to allow wrapping of metamask snaps (Sei and leap) with cosmjs offline signer compatible objects. This allows them to be used with the existing SeiWalletProvider.
The package /metamask-snap is experimental and won't be release until properly audited, but will be included in this codebase for local testing.