Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Metamask Snaps #103

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Feature: Metamask Snaps #103

merged 11 commits into from
Dec 13, 2023

Conversation

codebycarson
Copy link
Collaborator

Added helper functions to /core to allow wrapping of metamask snaps (Sei and leap) with cosmjs offline signer compatible objects. This allows them to be used with the existing SeiWalletProvider.

The package /metamask-snap is experimental and won't be release until properly audited, but will be included in this codebase for local testing.

… with other cosmos based libraries including @sei-js

- Refactored helper functions in /core
@codebycarson codebycarson requested a review from besated November 29, 2023 00:12
Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 676fde3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sei-js/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (15f0a37) 76.56% compared to head (676fde3) 76.51%.

Files Patch % Lines
packages/core/src/lib/utils/address.ts 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   76.56%   76.51%   -0.05%     
==========================================
  Files          35       35              
  Lines         512      511       -1     
  Branches      122      121       -1     
==========================================
- Hits          392      391       -1     
  Misses        120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,5 @@
---
'@sei-js/core': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we also need to bump metamask-snap version so that it has the correct core dependency?

}
}

export const sendReqToSnap = async (method: string, params: any): Promise<any> => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used for anything besides metamask-snap? if not, maybe we can just leave it in the metamask-snap package to keep the size of core as low as possible?

@codebycarson codebycarson merged commit 387cb59 into main Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants