Integrate with MinTxsInBlock #558
Merged
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
reviewed
Dec 27, 2024
baseapp/params.go
Outdated
| @@ -48,6 +48,10 @@ func ValidateBlockParams(i interface{}) error { | |||
| return fmt.Errorf("block maximum gas must be greater than or equal to -1: %d", v.MaxGas) | |||
| } | |||
|
|
|||
| if v.MinTxsInBlock < 0 { | |||
| return fmt.Errorf("block min txs in block must be positive: %d", v.MinTxsInBlock) | |||
| MaxGas: exported.ConsensusParams.Block.MaxGas, | ||
| MaxBytes: exported.ConsensusParams.Block.MaxBytes, | ||
| MaxGas: exported.ConsensusParams.Block.MaxGas, | ||
| MinTxsInBlock: exported.ConsensusParams.Block.MinTxsInBlock, |
There was a problem hiding this comment.
do we need a migration handler for thsi?
There was a problem hiding this comment.
no, just a param update proposal
codchen
force-pushed
the
integrate-min-tx-in-block
branch
from
8c72bce to
e3ebce4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 54.86% 54.87%
=======================================
Files 631 631
Lines 54946 54951 +5
=======================================
+ Hits 30145 30153 +8
+ Misses 22644 22640 -4
- Partials 2157 2158 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Pass through MinTxsInBlock between app side and tendermint side
Testing performed to validate your change
integrated with sei-chain and tested on local sei