Deeplink not getting tracked. #127
Open
+57
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rjaintwilio
commented
Nov 13, 2024
•
Rjaintwilio
commented
- Updated AnalyticsPlugin.kt to process deeplinks events when started from killed state.
- Updated state.dart file to make the referringApplication nullable.
- Removed deprecated application methods form AnalyticsPlugin.
packages/core/android/src/main/kotlin/com/segment/analytics/AnalyticsPlugin.kt
Outdated
Show resolved
Hide resolved
bsneed
reviewed
Nov 19, 2024
| @@ -216,7 +233,10 @@ class AnalyticsPlugin : FlutterPlugin, NativeContextApi, EventChannel.StreamHand | |||
| binding.addOnNewIntentListener(this) | |||
| if (this.context != null) { | |||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP_MR1) { | |||
| binding.activity.intent.putExtra("referringApplication", binding.activity.referrer.toString()) | |||
There was a problem hiding this comment.
this key should be "referrer" according to segment docs I believe.
There was a problem hiding this comment.
I can confirm it's "referrer" in analytics-kotlin.
Comment on lines
22
to
+24
| _eventSink?(["url": url.absoluteString, "referringApplication": sourceApplication]) | ||
| }else{ | ||
| pendingDeeplinkEventsQueue.append(["url": url.absoluteString, "referringApplication": sourceApplication]); |
didiergarcia
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.