Skip to content

Commit

Permalink
Electron is unsafe to load malicious code in. (#1234)
Browse files Browse the repository at this point in the history
* Electron is unsafe to load malicious code in.

Because Nightmarejs is built on top of electron, it's possible
to execute arbitrary code if a malicious website is loaded.

Electron provides a README that explicitly states that the code
you load is your responsibility, and so Nightmare must inherit
this principle.

* Bold. Not italics
  • Loading branch information
ejcx authored and fouad committed Aug 23, 2017
1 parent 0c9c0b1 commit b7be8a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Nightmare is a high-level browser automation library from [Segment](https://segm

The goal is to expose a few simple methods that mimic user actions (like `goto`, `type` and `click`), with an API that feels synchronous for each block of scripting, rather than deeply nested callbacks. It was originally designed for automating tasks across sites that don't have APIs, but is most often used for UI testing and crawling.

Under the covers it uses [Electron](http://electron.atom.io/), which is similar to [PhantomJS](http://phantomjs.org/) but roughly [2 times faster](https://github.com/segmentio/nightmare/issues/484#issuecomment-184519591) and more modern.
Under the covers it uses [Electron](http://electron.atom.io/), which is similar to [PhantomJS](http://phantomjs.org/) but roughly [2 times faster](https://github.com/segmentio/nightmare/issues/484#issuecomment-184519591) and more modern. **[Because Nightmare uses Electron, it is your responsibility to ensure that the webpages loaded by Nightmare are not malicious](https://github.com/electron/electron/blob/master/docs/tutorial/security.md). If you do load a malicious website, that website can execute arbitrary code on your computer.**

[Niffy](https://github.com/segmentio/niffy) is a perceptual diffing tool built on Nightmare. It helps you detect UI changes and bugs across releases of your web app.

Expand Down

0 comments on commit b7be8a7

Please sign in to comment.