Remove ontology attribute type #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added as isa_template_attributes, to be consistent with SampleType.isa_template (to avoid clash with general use of template)
moves sample and template attributes to CV, and then deletes the ontology one. Only deletes if both Ontology and CV attribute types are found
lead to some odd behaviour, and was based on custom_input rather than being based on an ontology
kdp-cloud
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
There is some old 'hash rocket' syntax in app/views/sample_types/_sample_attribute_form.html.erb and app/views/templates/_template_attribute_form.erb you might consider updating to the new JSON syntax.
Other than that, no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'Ontology'
SampleAttributeType, which was really a duplicate of 'Controlled Vocabulary'required removing some legacy javascript behaviour that filtered the list of CV's available, but based on
.custom_input?rather than whether they are ontology based.An upgrade task migrates existing sample attributes linked to 'Ontololgy' to 'Controlled Vocabularly'