Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make sure vanilla assays and studies can be deleted. #1607

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Bugfix: Make sure vanilla assays and studies can be deleted. #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/assays_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def create

def delete_linked_sample_types
return unless is_single_page_assay?
return if @assay.sample_type.nil?

@assay.sample_type.destroy
end
Expand Down
1 change: 1 addition & 0 deletions app/controllers/studies_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def update

def delete_linked_sample_types
return unless is_single_page_study?
return if @study.sample_types.empty?

# The study sample types must be destroyed in reversed order
# otherwise the first sample type won't be removed becaused it is linked from the second
Expand Down
Loading