Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename custom metadata to extended metadata.... #1606

Merged
merged 3 commits into from
Oct 9, 2023
Merged

rename custom metadata to extended metadata.... #1606

merged 3 commits into from
Oct 9, 2023

Conversation

whomingbird
Copy link
Contributor

  1. update model definitions
  2. new migrations to rename the column.
  3. update Views and Controllers.
  4. modify tests.
  5. update routes

@stuzart stuzart self-requested a review October 6, 2023 14:57
stuzart
stuzart requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@stuzart stuzart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one pedantic very minor change suggestion

will need a thorough test on the test server

app/models/concerns/has_extended_metadata.rb Outdated Show resolved Hide resolved
@whomingbird whomingbird merged commit 6d48385 into main Oct 9, 2023
25 checks passed
@whomingbird whomingbird deleted the 1393-rename-custom-metadata branch November 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuzart stuzart stuzart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whomingbird @stuzart