-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload samples through spreadsheet single page #1520
Merged
kdp-cloud
merged 57 commits into
seek4science:main
from
ELIXIR-Belgium:upload_samples_through_spreadsheet_single_page
Sep 20, 2023
Merged
Upload samples through spreadsheet single page #1520
kdp-cloud
merged 57 commits into
seek4science:main
from
ELIXIR-Belgium:upload_samples_through_spreadsheet_single_page
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added route to routes.rb - Extraction of sample information in the controller - Added a partial form with a button to upload the spreadsheet
…e database the current user has at least editing authorization for.
- Removed trailing `\n` from cells - Added more information to 'General Information' pane
… general information.
- added route to routes.rb - Extraction of sample information in the controller - Added a partial form with a button to upload the spreadsheet
…e database the current user has at least editing authorization for.
- Removed trailing `\n` from cells - Added more information to 'General Information' pane
… general information.
…ub.com:ELIXIR-Belgium/seek into upload_samples_through_spreadsheet_single_page
…es_through_spreadsheet_single_page
- Cancel button should close modal form - Clean-up and simplification
- Changed upload route from member to collection - Move Ajax call to the index.js file - Add function to the different tables
…es_through_spreadsheet_single_page
…readsheet extraction.
- Hide the button if no sample are added - Summarize samples the user does not have editing permissions for.
This was
linked to
issues
Aug 23, 2023
stuzart
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but no blockers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains functionality to create and update samples directly by uploading an Excel Spreadsheet.