fix for setting enable_starttls_auto to false rather than nil

seek4science · Apr 13, 2023 · 994b708 · 994b708
1 parent b36a8a7
commit 994b708
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/seek/config.rb b/lib/seek/config.rb
@@ -38,6 +38,8 @@ def smtp_propagate
       password =  smtp_settings 'password'
       smtp_hash['password'] = password
 
+      smtp_hash['enable_starttls_auto'] = false if smtp_hash['enable_starttls_auto'].nil?
+
       new_hash = {}
       smtp_hash.keys.each do |key|
         new_hash[key.to_sym] = smtp_hash[key]

diff --git a/test/unit/config_test.rb b/test/unit/config_test.rb
@@ -358,6 +358,14 @@ class ConfigTest < ActiveSupport::TestCase
     refute setting[:encrypted_value].include?(password)
   end
 
+  test 'set enable_starttls_auto to false' do
+    Seek::Config.set_smtp_settings 'enable_starttls_auto', false
+
+    # must be false and not nil
+    refute_nil ActionMailer::Base.smtp_settings[:enable_starttls_auto]
+    refute ActionMailer::Base.smtp_settings[:enable_starttls_auto]
+  end
+
   test 'doi_prefix, doi_suffix' do
     assert_equal '10.5072', Seek::Config.doi_prefix
     assert_equal 'Sysmo.SEEK', Seek::Config.doi_suffix