Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tests by using GinkgoT().TempDir() #1265

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

alexandear
Copy link
Contributor

The PR refactors tests by replacing os.MkdirTemp with GinkgoT().TempDir().

T.TempDir returns a temporary directory for the test to use. The directory is automatically removed when the test and all its subtests complete.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.66%. Comparing base (1216c9b) to head (ddb62cd).
Report is 18 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   68.49%   66.66%   -1.84%     
==========================================
  Files          75       75              
  Lines        4384     5186     +802     
==========================================
+ Hits         3003     3457     +454     
- Misses       1233     1581     +348     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccojocar ccojocar merged commit ef1a35f into securego:master Dec 16, 2024
6 checks passed
@alexandear alexandear deleted the refactor-test--t-tempdir branch December 16, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants