Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid allocations with
(*regexp.Regexp).MatchString
We should use `(*regexp.Regexp).MatchString` instead of `(*regexp.Regexp).Match([]byte(...))` when matching string to avoid unnecessary `[]byte` conversions and reduce allocations. Example benchmark: var defaultTagRegex = regexp.MustCompile("\n *#nosec") func BenchmarkMatch(b *testing.B) { for i := 0; i < b.N; i++ { if match := defaultTagRegex.Match([]byte("\n #nosec")); !match { b.Fail() } } } func BenchmarkMatchString(b *testing.B) { for i := 0; i < b.N; i++ { if match := defaultTagRegex.MatchString("\n #nosec"); !match { b.Fail() } } } goos: linux goarch: amd64 pkg: github.com/securego/gosec/v2 cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics BenchmarkMatch-16 5367033 210.6 ns/op 8 B/op 1 allocs/op BenchmarkMatchString-16 9321561 126.3 ns/op 0 B/op 0 allocs/op PASS ok github.com/securego/gosec/v2 3.606s Signed-off-by: Eng Zer Jun <[email protected]>
- Loading branch information