-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating naming conventions of different API #946
updating naming conventions of different API #946
Conversation
Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
This reverts commit bb6cf4d. Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
38600ca
to
3e834d6
Compare
…imental Signed-off-by: kta-intel <[email protected]>
Signed-off-by: kta-intel <[email protected]>
30c5cd3
to
09f87d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me Kevin.
Just a FYI for the future.
What is the difference between workflow_101 and workflow_1001 examples
Note from Patrick: "101 is the minimal example. 1001 is the same thing but includes workspace export. It should be renamed to a different number to avoid this type of confusion."
something to change in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewed the PR, which updates API naming conventions and fixes broken links. The changes from "aggregator-based workflow" to "Task Runner API," "director-based workflow" to "Interactive API," and "workflow interface" to "Workflow API" are correctly implemented throughout the code and documentation. All new links are functional.
The PR is accurate and ready for merge.
LGTM, Manuel
This PR:
TODO:
workflow_interface
notebook names toworkflow_api
andrequirements_workflow_interface.txt
torequirements_workflow_api.txt