Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Code changes due to TLS Parameter changes in openfl #1170

Merged
merged 11 commits into from
Nov 28, 2024
Merged

Test Code changes due to TLS Parameter changes in openfl #1170

merged 11 commits into from
Nov 28, 2024

Conversation

payalcha
Copy link
Contributor

@payalcha payalcha commented Nov 21, 2024 •
edited
Loading

Test Changes to accommodate #1167 .

  1. In Conftest.py remove duplication entries in pytest.addoption.
  2. Change the parameters name according to openfl standards as use_tls and require_client_auth
  3. Change the github yaml accordingly

Pass - https://github.com/payalcha/openfl/actions/runs/12062045715/job/33635087657

@payalcha
Change the input params
e4a992e 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha
use_tls and require_client_auth
33943fd 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha
Merge branch 'develop' into develop
6cb3e5c 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha payalcha changed the title Modify plan.yaml according to new flags Test Code changes due to TLS Parameter changes in openfl Nov 22, 2024
@payalcha
remove not
d85bc9f 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha
Small change in use-tls
1e215df 
Signed-off-by: Chaurasiya, Payal <[email protected]>
MasterSkepticista
MasterSkepticista requested changes Nov 22, 2024
View reviewed changes
tests/end_to_end/conftest.py Outdated Show resolved Hide resolved
tests/end_to_end/models/participants.py Outdated Show resolved Hide resolved
tests/end_to_end/models/participants.py Outdated Show resolved Hide resolved
tests/end_to_end/utils/conftest_helper.py Outdated Show resolved Hide resolved
tests/end_to_end/utils/conftest_helper.py Outdated Show resolved Hide resolved
tests/end_to_end/utils/conftest_helper.py Outdated Show resolved Hide resolved
@MasterSkepticista MasterSkepticista marked this pull request as ready for review November 27, 2024 12:18
@payalcha
Review comments
6fba6ee 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha
action needed for boolean
aa862e2 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha
Small fix
66f27f9 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@payalcha
Small fix
cc5e338 
Signed-off-by: Chaurasiya, Payal <[email protected]>
noopurintel
noopurintel reviewed Nov 28, 2024
View reviewed changes
.github/workflows/task_runner_e2e.yml Outdated Show resolved Hide resolved
tests/end_to_end/conftest.py Show resolved Hide resolved
@payalcha
Review comments
de6c6ee 
Signed-off-by: Chaurasiya, Payal <[email protected]>
@MasterSkepticista MasterSkepticista merged commit 00f2755 into securefederatedai:develop Nov 28, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noopurintel noopurintel noopurintel approved these changes

@MasterSkepticista MasterSkepticista MasterSkepticista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@payalcha @MasterSkepticista @noopurintel