Skip to content

Commit

Permalink
Resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
seconroy committed Nov 20, 2024
1 parent c412a21 commit ce4593b
Show file tree
Hide file tree
Showing 55 changed files with 221 additions and 218 deletions.
2 changes: 1 addition & 1 deletion docs/data-sources/policy_object_security_protocol_list.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ data "sdwan_policy_object_security_protocol_list" "example" {

Read-Only:

- `protocol_names` (String)
- `protocol_name` (String)
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,5 @@ data "sdwan_policy_object_unified_advanced_malware_protection" "example" {
- `file_analysis_alert_log_level` (String)
- `file_analysis_cloud_region` (String)
- `file_analysis_file_types` (Set of String)
- `match_all_vpn` (Boolean)
- `name` (String) The name of the Policy_object
- `version` (Number) The version of the Policy_object
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ data "sdwan_policy_object_unified_intrusion_prevention" "example" {
- `custom_signature` (Boolean) Can be one of the enum value
- `description` (String) The description of the Policy_object
- `inspection_mode` (String) Can be one of the enum value
- `ips_signature_list_id` (String)
- `ips_signature_allow_list_id` (String)
- `log_level` (String) Can be one of the enum value
- `name` (String) The name of the Policy_object
- `signature_set` (String) Can be one of the enum value
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ data "sdwan_policy_object_unified_tls_ssl_decryption" "example" {
- `default_ca_certificate_bundle` (Boolean)
- `description` (String) The description of the Policy_object
- `ec_key_type` (String)
- `enable_ssl` (Boolean) If false, no other fields should be provided, if true all fields should be provided
- `expired_certificate` (String)
- `failure_mode` (String)
- `file_name` (String)
Expand Down
4 changes: 2 additions & 2 deletions docs/resources/policy_object_security_protocol_list.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ resource "sdwan_policy_object_security_protocol_list" "example" {
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
entries = [
{
protocol_names = "aol"
protocol_name = "aol"
}
]
}
Expand Down Expand Up @@ -50,7 +50,7 @@ resource "sdwan_policy_object_security_protocol_list" "example" {

Optional:

- `protocol_names` (String) - Choices: `snmp`, `icmp`, `tcp`, `udp`, `echo`, `telnet`, `wins`, `n2h2server`, `nntp`, `pptp`, `rtsp`, `bootpc`, `gdoi`, `tacacs`, `gopher`, `icabrowser`, `skinny`, `sunrpc`, `biff`, `router`, `ircs`, `orasrv`, `ms-cluster-net`, `kermit`, `isakmp`, `sshell`, `realsecure`, `ircu`, `appleqtc`, `pwdgen`, `rdb-dbs-disp`, `creativepartnr`, `finger`, `ftps`, `giop`, `rsvd`, `hp-alarm-mgr`, `uucp`, `kerberos`, `imap`, `time`, `bootps`, `tftp`, `oracle`, `snmptrap`, `http`, `qmtp`, `radius`, `oracle-em-vp`, `tarantella`, `pcanywheredata`, `ldap`, `mgcp`, `sqlsrv`, `hsrp`, `cisco-net-mgmt`, `smtp`, `pcanywherestat`, `exec`, `send`, `stun`, `syslog`, `ms-sql-m`, `citrix`, `creativeserver`, `cifs`, `cisco-sys`, `cisco-tna`, `ms-dotnetster`, `gtpv1`, `gtpv0`, `imap3`, `fcip-port`, `netbios-dgm`, `sip-tls`, `pop3s`, `cisco-fna`, `802-11-iapp`, `oem-agent`, `cisco-tdp`, `tr-rsrb`, `r-winsock`, `sql-net`, `syslog-conn`, `tacacs-ds`, `h225ras`, `ace-svr`, `dhcp-failover`, `igmpv3lite`, `irc-serv`, `entrust-svcs`, `dbcontrol_agent`, `cisco-svcs`, `ipsec-msft`, `microsoft-ds`, `ms-sna`, `rsvp_tunnel`, `rsvp-encap`, `hp-collector`, `netbios-ns`, `msexch-routing`, `h323`, `l2tp`, `ldap-admin`, `pop3`, `h323callsigalt`, `ms-sql`, `iscsi-target`, `webster`, `lotusnote`, `ipx`, `entrust-svc-hand`, `citriximaclient`, `rtc-pm-port`, `ftp`, `aol`, `xdmcp`, `oraclenames`, `login`, `iscsi`, `ttc`, `imaps`, `socks`, `ssh`, `dnsix`, `daytime`, `sip`, `discard`, `ntp`, `ldaps`, `https`, `vdolive`, `ica`, `net8-cman`, `cuseeme`, `netstat`, `sms`, `streamworks`, `rtelnet`, `who`, `kazaa`, `ssp`, `dbase`, `timed`, `cddbp`, `telnets`, `ymsgr`, `ident`, `bgp`, `ddns-v3`, `vqp`, `irc`, `ipass`, `x11`, `dns`, `lotusmtap`, `mysql`, `nfs`, `msnmsgr`, `netshow`, `sqlserv`, `hp-managed-node`, `ncp`, `shell`, `realmedia`, `msrpc`, `clp`
- `protocol_name` (String) - Choices: `snmp`, `icmp`, `tcp`, `udp`, `echo`, `telnet`, `wins`, `n2h2server`, `nntp`, `pptp`, `rtsp`, `bootpc`, `gdoi`, `tacacs`, `gopher`, `icabrowser`, `skinny`, `sunrpc`, `biff`, `router`, `ircs`, `orasrv`, `ms-cluster-net`, `kermit`, `isakmp`, `sshell`, `realsecure`, `ircu`, `appleqtc`, `pwdgen`, `rdb-dbs-disp`, `creativepartnr`, `finger`, `ftps`, `giop`, `rsvd`, `hp-alarm-mgr`, `uucp`, `kerberos`, `imap`, `time`, `bootps`, `tftp`, `oracle`, `snmptrap`, `http`, `qmtp`, `radius`, `oracle-em-vp`, `tarantella`, `pcanywheredata`, `ldap`, `mgcp`, `sqlsrv`, `hsrp`, `cisco-net-mgmt`, `smtp`, `pcanywherestat`, `exec`, `send`, `stun`, `syslog`, `ms-sql-m`, `citrix`, `creativeserver`, `cifs`, `cisco-sys`, `cisco-tna`, `ms-dotnetster`, `gtpv1`, `gtpv0`, `imap3`, `fcip-port`, `netbios-dgm`, `sip-tls`, `pop3s`, `cisco-fna`, `802-11-iapp`, `oem-agent`, `cisco-tdp`, `tr-rsrb`, `r-winsock`, `sql-net`, `syslog-conn`, `tacacs-ds`, `h225ras`, `ace-svr`, `dhcp-failover`, `igmpv3lite`, `irc-serv`, `entrust-svcs`, `dbcontrol_agent`, `cisco-svcs`, `ipsec-msft`, `microsoft-ds`, `ms-sna`, `rsvp_tunnel`, `rsvp-encap`, `hp-collector`, `netbios-ns`, `msexch-routing`, `h323`, `l2tp`, `ldap-admin`, `pop3`, `h323callsigalt`, `ms-sql`, `iscsi-target`, `webster`, `lotusnote`, `ipx`, `entrust-svc-hand`, `citriximaclient`, `rtc-pm-port`, `ftp`, `aol`, `xdmcp`, `oraclenames`, `login`, `iscsi`, `ttc`, `imaps`, `socks`, `ssh`, `dnsix`, `daytime`, `sip`, `discard`, `ntp`, `ldaps`, `https`, `vdolive`, `ica`, `net8-cman`, `cuseeme`, `netstat`, `sms`, `streamworks`, `rtelnet`, `who`, `kazaa`, `ssp`, `dbase`, `timed`, `cddbp`, `telnets`, `ymsgr`, `ident`, `bgp`, `ddns-v3`, `vqp`, `irc`, `ipass`, `x11`, `dns`, `lotusmtap`, `mysql`, `nfs`, `msnmsgr`, `netshow`, `sqlserv`, `hp-managed-node`, `ncp`, `shell`, `realmedia`, `msrpc`, `clp`

## Import

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,17 @@ resource "sdwan_policy_object_unified_advanced_inspection_profile" "example" {

### Required

- `advanced_malware_protection_list_id` (String)
- `feature_profile_id` (String) Feature Profile ID
- `intrusion_prevention_list_id` (String)
- `name` (String) The name of the Policy_object
- `tls_decryption_action` (String) - Choices: `decrypt`, `neverDecrypt`, `skipDecrypt`
- `tls_ssl_profile_list_id` (String)
- `url_filtering_list_id` (String)

### Optional

- `advanced_malware_protection_list_id` (String)
- `description` (String) The description of the Policy_object
- `intrusion_prevention_list_id` (String)
- `tls_ssl_profile_list_id` (String)
- `url_filtering_list_id` (String)

### Read-Only

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ resource "sdwan_policy_object_unified_advanced_malware_protection" "example" {
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
match_all_vpn = true
amp_cloud_region = "nam"
amp_cloud_region_est_server = "nam"
alert_log_level = "critical"
Expand All @@ -40,15 +39,16 @@ resource "sdwan_policy_object_unified_advanced_malware_protection" "example" {
- `amp_cloud_region_est_server` (String) - Choices: `nam`, `eur`, `apjc`
- `feature_profile_id` (String) Feature Profile ID
- `file_analysis` (Boolean)
- `file_analysis_alert_log_level` (String) - Choices: `critical`, `warning`, `info`
- `file_analysis_cloud_region` (String) - Choices: `nam`, `eur`
- `file_analysis_file_types` (Set of String)
- `match_all_vpn` (Boolean)
- `name` (String) The name of the Policy_object

### Optional

- `description` (String) The description of the Policy_object
- `file_analysis_alert_log_level` (String) , Attribute conditional on `file_analysis` being equal to `true`
- Choices: `critical`, `warning`, `info`
- `file_analysis_cloud_region` (String) , Attribute conditional on `file_analysis` being equal to `true`
- Choices: `nam`, `eur`
- `file_analysis_file_types` (Set of String) , Attribute conditional on `file_analysis` being equal to `true`

### Read-Only

Expand Down
20 changes: 10 additions & 10 deletions docs/resources/policy_object_unified_intrusion_prevention.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ This resource can manage a Policy Object Unified Intrusion Prevention Policy_obj

```terraform
resource "sdwan_policy_object_unified_intrusion_prevention" "example" {
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
signature_set = "balanced"
inspection_mode = "detection"
ips_signature_list_id = "2ad58d78-59ee-46d3-86dd-7b6b7ca09f38"
log_level = "error"
custom_signature = false
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
signature_set = "balanced"
inspection_mode = "detection"
ips_signature_allow_list_id = "2ad58d78-59ee-46d3-86dd-7b6b7ca09f38"
log_level = "error"
custom_signature = false
}
```

Expand All @@ -32,11 +32,9 @@ resource "sdwan_policy_object_unified_intrusion_prevention" "example" {

### Required

- `custom_signature` (Boolean) Can be one of the enum value
- `feature_profile_id` (String) Feature Profile ID
- `inspection_mode` (String) Can be one of the enum value
- Choices: `detection`, `protection`
- `ips_signature_list_id` (String)
- `log_level` (String) Can be one of the enum value
- Choices: `emergency`, `alert`, `critical`, `error`, `warning`, `notice`, `info`, `debug`
- `name` (String) The name of the Policy_object
Expand All @@ -45,7 +43,9 @@ resource "sdwan_policy_object_unified_intrusion_prevention" "example" {

### Optional

- `custom_signature` (Boolean) Can be one of the enum value
- `description` (String) The description of the Policy_object
- `ips_signature_allow_list_id` (String)

### Read-Only

Expand Down
8 changes: 3 additions & 5 deletions docs/resources/policy_object_unified_tls_ssl_decryption.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ resource "sdwan_policy_object_unified_tls_ssl_decryption" "example" {
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
enable_ssl = true
expired_certificate = "drop"
untrusted_certificate = "drop"
certificate_revocation_status = "ocsp"
unknown_revocation_status = "decrypt"
unsupported_protocol_versions = "no-decrypt"
unsupported_protocol_versions = "drop"
unsupported_cipher_suites = "drop"
failure_mode = "close"
default_ca_certificate_bundle = true
Expand All @@ -44,15 +43,12 @@ resource "sdwan_policy_object_unified_tls_ssl_decryption" "example" {
- `certificate_revocation_status` (String) If value is none unknown status not required, if value is ocsp then unknown status is required
- Choices: `ocsp`, `none`
- `ec_key_type` (String) - Choices: `P256`, `P384`, `P521`
- `enable_ssl` (Boolean) If false, no other fields should be provided, if true all fields should be provided
- `expired_certificate` (String) - Choices: `decrypt`, `drop`
- `failure_mode` (String) - Choices: `close`, `open`
- `feature_profile_id` (String) Feature Profile ID
- `minimal_tls_ver` (String) - Choices: `TLSv1`, `TLSv1.1`, `TLSv1.2`
- `name` (String) The name of the Policy_object
- `rsa_keypair_modules` (String) - Choices: `1024`, `2048`, `4096`
- `unknown_revocation_status` (String) Only required if certificateRevocationStatus is oscp, if value is none then field shouldn't be here
- Choices: `decrypt`, `drop`
- `unsupported_cipher_suites` (String) - Choices: `no-decrypt`, `drop`
- `unsupported_protocol_versions` (String) - Choices: `no-decrypt`, `drop`
- `untrusted_certificate` (String) - Choices: `decrypt`, `drop`
Expand All @@ -63,6 +59,8 @@ resource "sdwan_policy_object_unified_tls_ssl_decryption" "example" {
- `default_ca_certificate_bundle` (Boolean)
- `description` (String) The description of the Policy_object
- `file_name` (String)
- `unknown_revocation_status` (String) Only required if certificateRevocationStatus is oscp, if value is none then field shouldn't be here, Attribute conditional on `certificate_revocation_status` being equal to `ocsp`
- Choices: `decrypt`, `drop`

### Read-Only

Expand Down
10 changes: 6 additions & 4 deletions docs/resources/policy_object_unified_tls_ssl_profile.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,22 @@ resource "sdwan_policy_object_unified_tls_ssl_profile" "example" {
### Required

- `decrypt_categories` (Set of String)
- `decrypt_threshold` (String) - Choices: `high-risk`, `low-risk`, `moderate-risk`, `suspicious`, `trustworthy`
- `fail_decrypt` (Boolean)
- `feature_profile_id` (String) Feature Profile ID
- `name` (String) The name of the Policy_object
- `no_decrypt_categories` (Set of String)
- `pass_through_categories` (Set of String)
- `reputation` (Boolean)
- `threshold_categories` (String) - Choices: `high-risk`, `low-risk`, `moderate-risk`, `suspicious`, `trustworthy`
- `url_allow_list_id` (String)
- `url_block_list_id` (String)

### Optional

- `decrypt_threshold` (String) , Attribute conditional on `reputation` being equal to `true`
- Choices: `high-risk`, `low-risk`, `moderate-risk`, `suspicious`, `trustworthy`
- `description` (String) The description of the Policy_object
- `threshold_categories` (String) , Attribute conditional on `reputation` being equal to `true`
- Choices: `high-risk`, `low-risk`, `moderate-risk`, `suspicious`, `trustworthy`
- `url_allow_list_id` (String)
- `url_block_list_id` (String)

### Read-Only

Expand Down
11 changes: 5 additions & 6 deletions docs/resources/policy_object_unified_url_filtering.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ resource "sdwan_policy_object_unified_url_filtering" "example" {
url_block_list_id = "2ad58d78-59ee-46d3-86dd-7b6b7ca09f38"
block_page_action = "text"
block_page_contents = "Access to the requested page has been denied. Please contact your Network Administrator"
redirect_url = "www.example.com"
enable_alerts = true
alerts = ["blacklist"]
}
Expand All @@ -37,22 +36,22 @@ resource "sdwan_policy_object_unified_url_filtering" "example" {

### Required

- `alerts` (Set of String)
- `block_page_action` (String) - Choices: `text`, `redirect-url`
- `block_page_contents` (String)
- `enable_alerts` (Boolean)
- `feature_profile_id` (String) Feature Profile ID
- `name` (String) The name of the Policy_object
- `redirect_url` (String)
- `url_allow_list_id` (String)
- `url_block_list_id` (String)
- `web_categories` (Set of String)
- `web_categories_action` (String) - Choices: `block`, `allow`
- `web_reputation` (String) - Choices: `high-risk`, `low-risk`, `moderate-risk`, `suspicious`, `trustworthy`

### Optional

- `alerts` (Set of String) , Attribute conditional on `enable_alerts` being equal to `true`
- `block_page_contents` (String) , Attribute conditional on `block_page_action` being equal to `text`
- `description` (String) The description of the Policy_object
- `redirect_url` (String) , Attribute conditional on `block_page_action` being equal to `redirect-url`
- `url_allow_list_id` (String)
- `url_block_list_id` (String)

### Read-Only

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resource "sdwan_policy_object_security_protocol_list" "example" {
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
entries = [
{
protocol_names = "aol"
protocol_name = "aol"
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ resource "sdwan_policy_object_unified_advanced_malware_protection" "example" {
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
match_all_vpn = true
amp_cloud_region = "nam"
amp_cloud_region_est_server = "nam"
alert_log_level = "critical"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
resource "sdwan_policy_object_unified_intrusion_prevention" "example" {
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
signature_set = "balanced"
inspection_mode = "detection"
ips_signature_list_id = "2ad58d78-59ee-46d3-86dd-7b6b7ca09f38"
log_level = "error"
custom_signature = false
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
signature_set = "balanced"
inspection_mode = "detection"
ips_signature_allow_list_id = "2ad58d78-59ee-46d3-86dd-7b6b7ca09f38"
log_level = "error"
custom_signature = false
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ resource "sdwan_policy_object_unified_tls_ssl_decryption" "example" {
name = "Example"
description = "My Example"
feature_profile_id = "f6dd22c8-0b4f-496c-9a0b-6813d1f8b8ac"
enable_ssl = true
expired_certificate = "drop"
untrusted_certificate = "drop"
certificate_revocation_status = "ocsp"
unknown_revocation_status = "decrypt"
unsupported_protocol_versions = "no-decrypt"
unsupported_protocol_versions = "drop"
unsupported_cipher_suites = "drop"
failure_mode = "close"
default_ca_certificate_bundle = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ resource "sdwan_policy_object_unified_url_filtering" "example" {
url_block_list_id = "2ad58d78-59ee-46d3-86dd-7b6b7ca09f38"
block_page_action = "text"
block_page_contents = "Access to the requested page has been denied. Please contact your Network Administrator"
redirect_url = "www.example.com"
enable_alerts = true
alerts = ["blacklist"]
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ attributes:
mandatory: true
attributes:
- model_name: protocolName
tf_name: protocol_names
tf_name: protocol_name
id: true
mandatory: true
example: aol
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,25 @@ attributes:
- model_name: refId
tf_name: intrusion_prevention_list_id
data_path: [intrusionPrevention]
ignore_mandatory: true
example: 2ad58d78-59ee-46d3-86dd-7b6b7ca09f38
test_value: sdwan_policy_object_unified_intrusion_prevention.test.id
- model_name: refId
tf_name: url_filtering_list_id
data_path: [urlFiltering]
ignore_mandatory: true
example: 2ad58d78-59ee-46d3-86dd-7b6b7ca09f38
test_value: sdwan_policy_object_security_url_allow_list.test.id
- model_name: refId
tf_name: advanced_malware_protection_list_id
data_path: [advancedMalwareProtection]
ignore_mandatory: true
example: 2ad58d78-59ee-46d3-86dd-7b6b7ca09f38
test_value: sdwan_policy_object_unified_advanced_malware_protection.test.id
- model_name: refId
tf_name: tls_ssl_profile_list_id
data_path: [sslDecryptionProfile]
ignore_mandatory: true
example: 2ad58d78-59ee-46d3-86dd-7b6b7ca09f38
test_value: sdwan_policy_object_unified_tls_ssl_profile.test.id

Expand Down Expand Up @@ -107,7 +111,6 @@ test_prerequisites: |
name = "TF_TEST_ADVANCED_MALWARE"
description = "My Example"
feature_profile_id = sdwan_policy_object_feature_profile.test.id
match_all_vpn = true
amp_cloud_region = "nam"
amp_cloud_region_est_server = "nam"
alert_log_level = "critical"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,48 @@ attributes:
test_value: sdwan_policy_object_feature_profile.test.id
- model_name: matchAllVpn
tf_name: match_all_vpn
value: true
value_type: "global"
example: true
- model_name: fileReputationCloudServer
tf_name: amp_cloud_region
mandatory: true
example: nam
- model_name: fileReputationEstServer
tf_name: amp_cloud_region_est_server
mandatory: true
example: nam
- model_name: fileReputationAlert
tf_name: alert_log_level
mandatory: true
example: critical
- model_name: fileAnalysisEnabled
tf_name: file_analysis
mandatory: true
example: true
- model_name: fileAnalysisCloudServer
tf_name: file_analysis_cloud_region
ignore_mandatory: true
conditional_attribute:
name: file_analysis
value: true
type: Bool
example: nam
- model_name: fileAnalysisFileTypes
tf_name: file_analysis_file_types
ignore_mandatory: true
conditional_attribute:
name: file_analysis
value: true
type: Bool
example: pdf
- model_name: fileAnalysisAlert
tf_name: file_analysis_alert_log_level
ignore_mandatory: true
conditional_attribute:
name: file_analysis
value: true
type: Bool
example: critical

test_prerequisites: |
Expand Down
Loading

0 comments on commit ce4593b

Please sign in to comment.