fix build for gcc 14 #3391
fix build for gcc 14 #3391
Conversation
| @@ -1979,7 +1979,7 @@ void LLPanelRegionTerrainInfo::initMaterialCtrl(LLTextureCtrl*& ctrl, const std: | |||
| if (!ctrl) return; | |||
|
|
|||
| // consume cancel events, otherwise they will trigger commit callbacks | |||
| ctrl->setOnCancelCallback([](LLUICtrl* ctrl, const LLSD& param) {}); | |||
| ctrl->setOnCancelCallback([this](LLUICtrl* ctrl, const LLSD& param) {}); | |||
There was a problem hiding this comment.
This change makes me raise my eyebrows. I can't think of a reason why a lambda with a literally empty body would need any bindings.
There was a problem hiding this comment.
It makes no sense in all of the changes in this PR.
There was a problem hiding this comment.
In fact, clang actively dislikes it:
/Users/runner/work/viewer/viewer/indra/newview/llinventorygallerymenu.cpp:329:85: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
329 | boost::function<void(std::string& slurl)> copy_slurl_to_clipboard_cb = [this](const std::string& slurl)
| ^~~~
1 error generated.
There was a problem hiding this comment.
gcc14 marks all changes as errors. Maybe all the errors it detects are false positives.
I was not able to build the viewer properly using gcc14 and gcc13 in my environment.
|
gcc 14 or 13 error list
|
|
Maybe we must tell gcc users to skip versions 13 and 14? We certainly can't accept changes that break clang builds. |
|
Skipping gcc 13 and 14 may be appropriate. |
|
Since there is no prospect of being able to build with gcc13 and 14, I am thinking of canceling this PR. What do you think? |
Fix build error for gcc 14
It has not yet been completely fixed.
There may be some false positives.