Server#1036 A blocked user should not be able to gift L$ #3338
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchcat
approved these changes
Jan 3, 2025
| name="CantTransfterMoneyAgentIsBlocked" | ||
| type="notify"> | ||
| <tag>fail</tag> | ||
| Unable to make payment due to agent is blocked by the recipient. |
There was a problem hiding this comment.
"Unable to make payment due to the agent being blocked by the recipient." would be smoother.
There was a problem hiding this comment.
Agree, incorrect tense. But might be better to remake it more
"Unable to make payment due recipient blocking the transaction."
Also not sure if it's a good idea to expose the fact that you are blocked, people might start 'probing' block list that way even if it costs them.
There was a problem hiding this comment.
@vir-linden please take a look.
There was a problem hiding this comment.
It seems to be an UI/UX question: I bet @vir-linden will send us to @Steeltoe-Linden :-)
akleshchev
requested review from
Rider-Linden and
vir-linden
and removed request for
Rider-Linden and
akleshchev
akleshchev
approved these changes
Jan 4, 2025
LLGuru
force-pushed
the
guru/server-1036-blocked_user_should_not_be_able_to_gift_money
branch
from
9808b68 to
27eb010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewer-part of the solution for https://github.com/secondlife/server/issues/1036