#1611 Regression in anti-flipping mechanism for mouselook camera #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLGuru
force-pushed
the
guru/viewer-1611-anti-flipping
branch
4 times, most recently
from
06bfdd2 to
5af2927
Compare
marchcat
reviewed
Jun 12, 2024
|
I rezzed a Kart 1.0, rode it, entered mouselook and when I look up camera flips to the other orientation. I think that's a regression of viewer#1200. Also won't it cause conflicts with your change in maint-A? But Kart and tank are working fine when on a vertical surface. Was able to raise tank's barrel without issues. Didn't notice any other issues with camera. |
akleshchev
approved these changes
Jun 13, 2024
akleshchev
reviewed
Jun 13, 2024
marchcat
approved these changes
Jun 13, 2024
LLGuru
force-pushed
the
guru/viewer-1611-anti-flipping
branch
from
5af2927 to
631e859
Compare
LLGuru
force-pushed
the
guru/viewer-1611-anti-flipping
branch
2 times, most recently
from
a78970e to
4912238
Compare
LLGuru
force-pushed
the
guru/viewer-1611-anti-flipping
branch
from
4912238 to
563b6b8
Compare
marchcat
reviewed
Jun 14, 2024
LLGuru
force-pushed
the
guru/viewer-1611-anti-flipping
branch
from
0993a93 to
65911af
Compare
|
Personaly I keep a 'do not touch' policy with math classes. They work and they work well and had worked for years, changing anything, especially en masse always has a chance to break something for no benefit besides looking pretier. |
|
Right, it's usually no point in fixing what isn't broken. Not to mention that it can (and often does) introduce some new bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.