Fix conflicting bookings login filter

[aileo]

Hi,

I found out that when selecting a time range overlapping user's existing booking and someone else's booking on a seat, the delete action deletes both bookings.

I think the cause is in WarpSeatFactory.getMyConflictingBookings :

!i.book.login == this.login casts i.book.login as boolean first then compare its opposite value to this.login.

i.book.login != this.login checks if values are different.

Another way to do it could be !(i.book.login == this.login)

[Anbcorp]

Hello,

I tested this fix locally with docker-compose and it seems to fix the issue.

Thanks,

[sebo-b]

Hi @aileo

I'm looking for a maintainer for this project, as I've not been able to spend much time on it recently. It seems that you have contributed a lot so far, so please let me know if you are interested.

Regards,
/S

[aileo]

Hi @sebo-b,

I would be happy to help but I am not a python dev so it seems a bit over the top to me.

I hope you find someone to take over

[sebo-b]

Hi, IIRC (and it was a few years when I created this project, so basically I can be wrong) this is an intended behaviour. If you are the admin and select other user booking (even if it only partially overlaps with your time range) all bookings in the range are deleted. If you are a normal user, it should delete only your booking. Can you please check it? Regards, /S

…

On Friday, November 29th, 2024 at 2:28 PM, Léo Bonnargent ***@***.***> wrote: Hi ***@***.***(https://github.com/sebo-b), I would be happy to help but I am not a python dev so it seems a bit over the top to me. I hope you find someone to take over — Reply to this email directly, [view it on GitHub](#40 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AMKP4GTMIFPOMKCGZAHZSDT2DBTXRAVCNFSM6AAAAABSXD43DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBXHAZDCMJTGQ). You are receiving this because you were mentioned.Message ID: ***@***.***>

[aileo]

I had a quick look at it, here are the steps:

• user1 books from 6:00 to 9:00
• user2 books from 3:00 to 6:00
• user2 tries to book from 2:00 to 8:00

without fix:

• it says it will remove both 3:00 to 6:00 (user2) and 6:00 to 9:00 (user1)
• fails to delete reservations and display an error (102) if user2 is not an admin

with this fix:

• it says it will delete only 3:00 to 6:00 (even if user2 is an admin)
• actually delete the reservation

Anyway, the condition !i.book.login == this.login will always be false in javascript as it first casts i.book.login to a boolean before comparing to this.login. As an example from the node console:

> !'foo' == 'bar';
false
> 'foo' != 'bar';
true

Let me know if you want some modification in the PR.