This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
feat(fonts): adding Book weight #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsjolander
force-pushed
the
feat/book-weight
branch
from
2996116 to
3003332
Compare
BREAKING CHANGES: line height adjusted in all font files
vsjolander
force-pushed
the
feat/book-weight
branch
from
3003332 to
021fe4c
Compare
|
Additional things to add:
|
|
Hey, is this ready to be merged and released? |
splashdust
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Looks good to me!
According to the Semantic Release docs, the exact wording to trigger a major release is BREAKING CHANGE: (without the S at the end). Not sure how sensitive it is, but I think the best course of action will be to do a squash and merge, and add that exact wording in the squash commit message.
|
Are you able to supply |
|
@believer This package currently only supports web. For TTF and OTF fonts you should head to https://brand.seb.se/ |
|
@splashdust Awesome, thanks! |
astrit
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the font files and scss for the new Book weight.